Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Add in command to tap cask #15731

Closed
wants to merge 1 commit into from
Closed

README.md: Add in command to tap cask #15731

wants to merge 1 commit into from

Conversation

adidalal
Copy link
Contributor

@adidalal adidalal commented Dec 9, 2015

As we no longer get automatically installed by homebrew, let's add in the tap command to the readme again

As we no longer get automatically installed by homebrew, let's add in the tap command to the readme again
@adidalal adidalal added the documentation Issue regarding documentation. label Dec 9, 2015
@adidalal
Copy link
Contributor Author

adidalal commented Dec 9, 2015

Merged as e48fcbe.

@adidalal adidalal closed this Dec 9, 2015
@adidalal adidalal deleted the update-readme branch December 9, 2015 22:25
@vitorgalvao
Copy link
Member

We do still get automatically installed.

If you’re thinking of the recent submission by @jawshooah to homebrew, what he’s doing there is removing the specific install command, but just because it is no longer needed since #15381.

@adidalal
Copy link
Contributor Author

adidalal commented Dec 9, 2015

@vitorgalvao I'm confused then, why is brew tap caskroom/cask needed on caskroom.io at all then? (or more generically, when should we be telling people to brew tap caskroom/cask)

@jawshooah
Copy link
Contributor

Only reason I can think of is to protect against the Homebrew team changing their minds about auto-installing us.

@adidalal
Copy link
Contributor Author

adidalal commented Dec 9, 2015

Ah I see, this PR can likely be reverted then, though there's probably no harm in keeping it.
Up to you!

@vitorgalvao
Copy link
Member

I was thinking about possible user confusion. If we don’t have a “how to install” section on the website, I envision users getting confused about how to get HBC. On the other hand, explaining “you don’t need to do anything, as homebrew will take care of everything for you” seems like it may be confusing as well.

Since the website is more user-friendly (“do this”) and the repo is more developer-friendly (“do this, and here’s why”), I was thinking it would make sense and be helpful to have that instruction just on the website (to prevent about the mentioned user confusion).

I do believe we should remove the tap instruction from the repo. As for the website, I’m very open to whatever you think best.

adidalal pushed a commit that referenced this pull request Dec 9, 2015
@adidalal
Copy link
Contributor Author

adidalal commented Dec 9, 2015

Reverted in e8ff79f

I'll take a closer look at the website as time permits

@miccal miccal removed the documentation Issue regarding documentation. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants