Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix triumph.rb: Remove DDP Player.app artifact #21413

Merged
merged 1 commit into from
May 24, 2016
Merged

Fix triumph.rb: Remove DDP Player.app artifact #21413

merged 1 commit into from
May 24, 2016

Commits on May 24, 2016

  1. Fix triumph.rb: Remove DDP Player.app artifact 

    Triumph.app contains in its bundle three helper tools. Those tools are meant to be accessed from the menu bar while using Triumph.

One of those tools, DDP Player.app, is defined as an artifact though. With upcoming PR #13966, `cask install` would rip out DDP Player.app from the bundle. As a consequence, invoking the *DDP Player* menu item would cause Triumph to crash.

This commit fixes the issue by removing the artifact altogether. All the tools (including DDP Player) should be launched from the *Tools* menu as intended, e. g.:

> Triumph » Tools » DDP Player
    @claui
    claui committed May 24, 2016
    Configuration menu
    Copy the full SHA
    bbb7ace View commit details
    Browse the repository at this point in the history