Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated jabref (3.4) #21765

Merged
merged 1 commit into from
Jun 7, 2016

Conversation

joeygravlin
Copy link
Contributor

Changes to a cask

Editing an existing cask

  • Commit message includes cask’s name (and new version, if applicable).
  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.

@vitorgalvao vitorgalvao merged commit a81cf97 into Homebrew:master Jun 7, 2016
@joeygravlin joeygravlin deleted the cask-repair_update-jabref branch June 7, 2016 21:22
@joeygravlin
Copy link
Contributor Author

joeygravlin commented Jun 7, 2016

So...I'm a little embarrassed that I didn't catch this before submitting a pull request, but after actually installing the new version, I realized that there was an issue with their 3.4 build on OS X. After all of two seconds of browsing jabref's issues page, I found someone had already reported both the issue and a temporary fix in jabref issue #1481.

Anyway, I can confirm @KojiYokota's report that running the app using java -jar path/to/JabRef.app/Contents/java/app/JabRef-3.4.jar & works fine. However, I'll leave it to your discretion, @vitorgalvao, whether this will suffice in the interim, or if it would be better to just roll back this pull request.

@vitorgalvao
Copy link
Member

@joeygravlin Should be fine. Seems like they’ll look into a fix soon.

chizmw pushed a commit to chizmw/homebrew-cask that referenced this pull request Jun 15, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants