Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update virtualbox - add uninstall preflight #35226

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Update virtualbox - add uninstall preflight #35226

merged 1 commit into from
Jun 6, 2017

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Jun 5, 2017

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Checks to see if virtualbox-extension-pack exists at "#{HOMEBREW_PREFIX}/Caskroom/virtualbox-extension-pack" and uninstalls if it is found.

#29301 (comment)
virtualbox was updated today with a minor version change which happens to be a dependent of virtualbox-extension-pack. Reinstall works fine, but then the extension pack is missing because everything had been deleted even though cask shows the package as installed.

I've had this happen a few times with updates or switching between virtualbox / virtualbox-beta, also you can't uninstall virtualbox-extension-pack without virtualbox.

/cc @colindunn

@colindunn
Copy link
Contributor

Makes sense to me but it would mean that you have to install the extension pack again as a slight gotya. Seems like a reasonable trade-off.

@miccal miccal merged commit 6d162da into Homebrew:master Jun 6, 2017
@commitay commitay deleted the vbox-flight branch June 6, 2017 01:37
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants