Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapel 1.28.0 #110783

Closed
Closed

Conversation

bhavanijayakumaran
Copy link
Contributor

This is a new version of chapel formula for chapel 1.28.0 release.

Signed-off-by: bhavanijayakumaran 82669529+bhavanijayakumaran@users.noreply.github.com

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Signed-off-by: bhavanijayakumaran <82669529+bhavanijayakumaran@users.noreply.github.com>
@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Sep 15, 2022
@carlocab
Copy link
Member

Let's wait a bit to see how CI at #106925 goes. I don't want to be forced to rebase there since CI takes a long time.

@bradcray
Copy link

Hi @carlocab — Just to make sure I'm understanding the situation: Is your hope that the current CI checks on #106925 will pass in the current run, that you'll merge today, and then we'll resolve conflicts between this PR and that one? If the checks on #106925 do not pass on this run, will this PR be able to proceed, or might it be held off for a few days in favor of #106925?

(I'm asking from the perspective of how we should phrase our release announcement today w.r.t. homebrew availability and how long I should wait to make that call).

Thanks!

@bradcray
Copy link

bradcray commented Sep 15, 2022

@carlocab / @chenrui333: From what we're seeing, it looks as though #106925 is not passing its CI (and, happily, not due to any of the Chapel dependencies, at least for the cases I've looked at so far). That makes me wonder whether we have any chance of getting this merged today (our release day), or whether we need to caveat our release announcement to say "except for homebrew" because it's going to take several more days. Thanks!

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab
Copy link
Member

@bradcray your observations are all correct. I've merged this now. Apologies for any delay we've caused your release!

@bradcray
Copy link

No trouble at all, I definitely understand why waiting would've benefitted that formula. Sorry that there are still issues to work through, and thanks for merging. I hadn't quite hit send on my announcement, and am glad to be able to remove the "no homebrew" caveat. :)

I believe that the changes to the formula here should not be at all difficult to merge into your PR, but please let us know if we can be of any assistance.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants