Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencascade 7.7.0 #115638

Closed
wants to merge 5 commits into from
Closed

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Nov 13, 2022
@chenrui333 chenrui333 force-pushed the bump-opencascade-7.7.0 branch from 5385c4f to 8ef4e1f Compare November 13, 2022 20:02
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale No recent activity label Nov 16, 2022
@chenrui333 chenrui333 added long build Set a long timeout for formula testing in progress Stale bot should stay away and removed stale No recent activity labels Nov 16, 2022
@cho-m cho-m added build failure CI fails while building the software linux Linux is specifically affected labels Nov 16, 2022
@cho-m
Copy link
Member

cho-m commented Nov 16, 2022

Linux opencascade build failure:

/tmp/opencascade-20221113-19908-1gmwbky/occt-V7_7_0/src/ViewerTest/ViewerTest_CmdParser.cxx:53:80: error: ‘numeric_limits’ is not a member of ‘std’
     53 | const std::size_t ViewerTest_CmdParser::THE_UNNAMED_COMMAND_OPTION_KEY = (std::numeric_limits<std::size_t>::max)();
        |                                                                                ^~~~~~~~~~~~~~

@mistydemeo
Copy link
Member

std::numeric_limits is defined by <limits.h>: https://en.cppreference.com/w/cpp/types/numeric_limits

Guessing it's pulled in transitively in some envionments but not others.

@cho-m cho-m added the upstream issue An upstream issue report is needed label Nov 17, 2022
@cho-m
Copy link
Member

cho-m commented Nov 17, 2022

Some related upstream issues:
https://tracker.dev.opencascade.org/view.php?id=33157
https://tracker.dev.opencascade.org/view.php?id=33200

The patch in one of them has unnecessary changes.

GitHub mirror has some simpler patches (https://github.com/Open-Cascade-SAS/OCCT/pulls) but those will get auto-closed since OpenCascade doesn't use GitHub for issues/patches.

@SMillerDev
Copy link
Member

Could you suggest one of those pull requests as a patch upstream?

@ZhongRuoyu ZhongRuoyu force-pushed the bump-opencascade-7.7.0 branch 2 times, most recently from cb9e594 to 143ff81 Compare March 16, 2023 16:30
@ZhongRuoyu
Copy link
Member

This was fixed by this commit on 2022-12-04.

chenrui333 and others added 5 commits March 17, 2023 02:44
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
The location of `tcl-tk` headers was changed in Homebrew#124056.
@ZhongRuoyu ZhongRuoyu force-pushed the bump-opencascade-7.7.0 branch from 143ff81 to 608120c Compare March 16, 2023 18:45
@ZhongRuoyu ZhongRuoyu added CI-requeued PR has been re-added to the queue CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed upstream issue An upstream issue report is needed labels Mar 16, 2023
@chenrui333 chenrui333 removed CI-requeued PR has been re-added to the queue in progress Stale bot should stay away build failure CI fails while building the software labels Mar 17, 2023
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. linux Linux is specifically affected CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Mar 17, 2023
@chenrui333
Copy link
Member Author

Thanks @ZhongRuoyu!! 🚀

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@chenrui333 chenrui333 deleted the bump-opencascade-7.7.0 branch January 22, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants