Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen: depend on libxcrypt #117193

Closed
wants to merge 1 commit into from
Closed

screen: depend on libxcrypt #117193

wants to merge 1 commit into from

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Dec 3, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Summary

To fix a problem on Linux loading the libcrypt shared library, this PR introduces a dependency on Linux on libxcrypt. This is the same solution as in #108663.

Background

I am running the following:

Operating System: Debian GNU/Linux 11 (bullseye)  
          Kernel: Linux 5.10.0-18-amd64
    Architecture: x86-64

After installing GNU Screen, I see the following error when trying to run screen:

screen: error while loading shared libraries: libcrypt.so.1: cannot open shared object file: No such file or directory

I believe this is a result of changes to glibc that removed libcrypt (see here, here and here). Adding a dependency on libxcrypt solves the problem.

@chenrui333 chenrui333 added the linux Linux is specifically affected label Dec 3, 2022
Copy link
Member

@danielnachun danielnachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. I guess this was unnoticed before because screen must not have been tested in CI for a long time.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@pyrmont pyrmont deleted the bugfix.screen branch December 5, 2022 04:23
@pyrmont
Copy link
Contributor Author

pyrmont commented Dec 5, 2022

@danielnachun No worries. I imagine most people who are on Linux would be using tmux ;) Thanks for merging it in so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux Linux is specifically affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants