sundials 6.5.0 #119907
Closed
sundials 6.5.0 #119907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho-m
commented
Jan 6, 2023
| -DBUILD_SHARED_LIBS=ON | ||
| -DKLU_ENABLE=ON | ||
| -DKLU_LIBRARY_DIR=#{Formula["suite-sparse"].opt_lib} | ||
| -DKLU_INCLUDE_DIR=#{Formula["suite-sparse"].opt_include} | ||
| -DLAPACK_ENABLE=ON | ||
| -DBLA_VENDOR=OpenBLAS |
There was a problem hiding this comment.
CMake Warning:
Manually-specified variables were not used by the project:
BLA_VENDOR
p-linnane
previously approved these changes
Jan 6, 2023
cho-m
added
long build
cho-m
force-pushed
the
bump-sundials-6.5.0
branch
2 times, most recently
from
c333f5d to
d830b3b
Compare
cho-m
added
the
CI-long-timeout
cho-m
force-pushed
the
bump-sundials-6.5.0
branch
from
d830b3b to
37376c9
Compare
p-linnane
approved these changes
Jan 7, 2023
cho-m
removed
the
CI-long-timeout
chenrui333
approved these changes
Jan 7, 2023
|
🤖 A scheduled task has triggered a merge. |
mmuetzel
reviewed
Jan 12, 2023
| @@ -82,6 +82,9 @@ def install | |||
| /%OCTAVE_CONF_OCT(AVE)?_LINK_(DEPS|OPTS)%/, | |||
| '""' | |||
|
|
|||
| # SUNDIALS 6.4.0 and later needs C++14 for C++ based features | |||
| ENV.append "CXXFLAGS", "-std=c++14" | |||
There was a problem hiding this comment.
It would be better to set it to -std=gnu++14 because Octave uses some GNU extensions (and only falls back to some inferior workarounds if they aren't available).
Also, setting this only in CXXFLAGS might cause some preprocessor tests to get different results during configuration than what the compiler would see when building.
It might be better to add this flag to CXX.
There was a problem hiding this comment.
@cho-m: I hope it is ok to comment on a closed PR. But this should definitely be fixed in the build rules for the packaged Octave.
I.e.:
Suggested change
| ENV.append "CXXFLAGS", "-std=c++14" | |
| ENV.append "CXX", "-std=gnu++14" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Will need rebase if we merge #118915.