Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcl-tk: Fix ttk::ThemeChanged errors #130971

Closed

Conversation

chrstphrchvz
Copy link
Contributor

This error is an annoyance particularly for Tkinter users (see e.g. python/cpython#71383); it will be fixed in Tk 8.6.14.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This error is an annoyance particularly for Tkinter users
(see e.g. python/cpython#71383); it will be fixed in Tk 8.6.14.
@fxcoudert fxcoudert added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 29, 2023
gromgit pushed a commit to gromgit/homebrew-core that referenced this pull request Jun 10, 2023
This matches the Debian/Ubuntu naming thereof, to resolve naming conflicts like Homebrew#132885 (comment).

Also cherry-picked Ttk patch from Homebrew#130971.
@carlocab
Copy link
Member

Will be merged in #133143. Thanks!

@carlocab carlocab closed this Jun 10, 2023
@chrstphrchvz chrstphrchvz deleted the patch-ttkthemechanged branch June 10, 2023 21:03
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants