percona-xtrabackup 8.0.32-26

[jkrauska]

Created with brew bump-formula-pr.

Attempt at redoing #131036

Two main issues:

• boost check patch needed updating
• use mysql [1] instead of mysql-client due to bad linker settings remain in mysql-client (full mysql makes more sense anyway as you need a server to use xtrabackup anyway)

1. mysql PR from a week back
   mysql: fix bad linker flags in mysql_config #131207

• resource blocks have been checked for updates.

license ref:

https://github.com/percona/percona-xtrabackup/#licensing
https://github.com/search?q=repo%3Apercona%2Fpercona-xtrabackup%20General%20Public%20License&type=code

[chenrui333]

thanks for taking on this :)

[jkrauska]

thanks for taking on this :)

I'm new so this is tricky, but I'm interested in figuring it out.

[jkrauska]

arm builds all worked. x86s were taking longer. let's see tomorrow! 🤞

[carlocab]

Linux is failing with

  /tmp/percona-xtrabackup-20230526-28878-iem1vs/percona-xtrabackup-8.0.32-26/storage/innobase/xtrabackup/src/utils.cc:26:10: fatal error: proc/sysinfo.h: No such file or directory
     26 | #include <proc/sysinfo.h>
        |          ^~~~~~~~~~~~~~~~

@Homebrew/linux?

[jkrauska]

All complete except for Linux.
Adding procps to linux requires wasn't helpful.

Percona currently provides MANY Linux binary packages on their download pages.
(Debian, RHEL, Centos, Ubuntu and "Generic")

It's MacOS builds which are completely missing and the major value I find with having this HomeBrew Formula.

Is it reasonable to disable Linux builds for this version?

[jkrauska]

Thread on percona forum suggesting procps-ng-devel is required.

https://forums.percona.com/t/arm-compile-error-percona-xtrabackup-80-8-0-32-26-1-generic-src-rpm/21534

[jkrauska]

Current procps package in homebrew in version 4.

This ticket on Percona's JIRA highlights the issue of compatibility with version 4 and lack of cmake check.

https://jira.percona.com/browse/PXB-2993?jql=text%20~%20%22sysinfo.h%22

will try patching.

[jkrauska]

@chenrui333 Do you have a position on the need for the Linux builds?

I think it might be possible to down-rev the procps formula and/or make an intentional procps-devel formula, but I don't know enough about the Linux use cases for Homebrew.

My struggle is that I don't have easy access to a Linux test platform so the test loop takes nearly an hour to run through GH CI, and that's wasteful.

[carlocab]

Which version of procps is needed? We can add a versioned formula for it if we need an older one.

[jkrauska]

Which version of procps is needed? We can add a versioned formula for it if we need an older one.

The notes here: https://jira.percona.com/browse/PXB-2993?jql=text%20~%20%22sysinfo.h%22
Suggest that procps 3 is required.

But note that it's the development headers (which I'm not sure are even installed in the normal package) that are needed here. Not the lib itself. (typically they would reside in a -devel package in rpm/deb speak). I'm not sure what the equivalent is in brew and wasn't able to find any packages labeled '-devel'.

[jkrauska]

The equivalent debian package is:
https://packages.debian.org/bullseye/libprocps-dev

I can attempt to create a corresponding brew formulae, and then link it to this work.

[jkrauska]

Update: put together a Debian VM, so I could install HomeBrew and the procps formula.

It includes
./Cellar/procps/4.0.3/include/libproc2/misc.h
Which looks like a promising include.

[jkrauska]

New error:

  /tmp/percona-xtrabackup-20230529-29318-6ls2d2/percona-xtrabackup-8.0.32-26/storage/innobase/xtrabackup/src/utils.cc: In function ‘long unsigned int xtrabackup::utils::host_total_memory()’:
  /tmp/percona-xtrabackup-20230529-29318-6ls2d2/percona-xtrabackup-8.0.32-26/storage/innobase/xtrabackup/src/utils.cc:144:3: error: ‘meminfo’ was not declared in this scope
    144 |   meminfo();
        |   ^~~~~~~
  /tmp/percona-xtrabackup-20230529-29318-6ls2d2/percona-xtrabackup-8.0.32-26/storage/innobase/xtrabackup/src/utils.cc:145:10: error: ‘kb_main_total’ was not declared in this scope
    145 |   return kb_main_total * 1024;
        |          ^~~~~~~~~~~~~
  /tmp/percona-xtrabackup-20230529-29318-6ls2d2/percona-xtrabackup-8.0.32-26/storage/innobase/xtrabackup/src/utils.cc: In function ‘long unsigned int xtrabackup::utils::host_free_memory()’:
  /tmp/percona-xtrabackup-20230529-29318-6ls2d2/percona-xtrabackup-8.0.32-26/storage/innobase/xtrabackup/src/utils.cc:149:3: error: ‘meminfo’ was not declared in this scope
    149 |   meminfo();
        |   ^~~~~~~
  /tmp/percona-xtrabackup-20230529-29318-6ls2d2/percona-xtrabackup-8.0.32-26/storage/innobase/xtrabackup/src/utils.cc:150:10: error: ‘kb_main_available’ was not declared in this scope
    150 |   return kb_main_available * 1024;
        |          ^~~~~~~~~~~~~~~~~
  make[2]: *** [storage/innobase/xtrabackup/src/CMakeFiles/xtrabackup.dir/build.make:443: storage/innobase/xtrabackup/src/CMakeFiles/xtrabackup.dir/utils.cc.o] Error 1

There's also a meminfo.h.

Check it vs misc.h for comparisons.

[jkrauska]

kb_main_total is only defined in procps version 3. (not 4)

[jkrauska]

It looks like I'd need a /new/ Formula procps@3.rb
If this completes, I'll use that approach (instead of overriding the current procps at 4)

[carlocab]

Looks like it wants an @4 alias.

cd Aliases
ln -s ../Formula/procps.rb procps@4

Yep, done.

[carlocab]

My approval here won't unlock the merge since I pushed to this PR, but another maintainer should approve this soon.

Thanks for your work here, @jkrauska! This was very nice work.

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.

[github-actions]

⚠️ Bottle publish failed. CC @carlocab

bottle publish failed

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.

[github-actions]

⚠️ Bottle publish failed. CC @carlocab

bottle publish failed

[github-actions]

@carlocab has requested bottles to be published to this PR.

[github-actions]

⚠️ @carlocab bottle publish failed. CC @carlocab

bottle publish failed

[github-actions]

@carlocab has requested bottles to be published to this PR.