Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt 1.18.0 #149230

Merged
merged 2 commits into from
Oct 3, 2023
Merged

dolt 1.18.0 #149230

merged 2 commits into from
Oct 3, 2023

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

  • 6760: dolt backup: Fix dropped error on the final stage of updating the destination with the newly pushed backup.
  • 6754: go/libraries/doltcore/sqle/cluster: Replicate DROP DATABASE statements so that a dropped database is also dropped on replicas.
  • 6753: adds message column to dolt_push output
    Adds a message column to the output of dolt_push() to provide additional information.
  • 6752: go/libraries/doltcore/sqle/cluster: Fix a possible deadlock in permissions replication.

go-mysql-server

  • 2047: Don't reorder joins that are too large to efficiently analyze.
    The current implementation of the join order builder scales poorly if there are too many joins. It's likely possible to improve it, but in the meantime, I'm disabling join reordering on joins that have too many tables (currently defined to be more than 20.)
    In these situations, the analyzer takes longer to run the reordering than it does to actually execute any of our test cases, so running the analysis in this case can only slow us down.
    I expect this is unlikely to adversely affect users because joins this large are rare, and when they do occur they are often written in a way that the explicit order is good enough.
    For example, this test from sqllogictests:
    SELECT x63,x53,x62,x52,x11,x5,x40,x64,x27,x28,x21,x41,x22,x30,x16,x14,x56,x32,x46,x50,x1,x34   FROM t46,t34,t1,t32,t53,t21,t63,t11,t30,t62,t27,t50,t16,t64,t40,t56,t22,t28,t52,t5,t41,t14  WHERE a21=b5    AND b30=a52    AND a62=b46    AND a14=3    AND b52=a28    AND b53=a14    AND a63=b28    AND b40=a56    AND a11=b64    AND a53=b22    AND b1=a34    AND b32=a41    AND a50=b63    AND a64=b62    AND b11=a30    AND b27=a40    AND a22=b56    AND b21=a46    AND a1=b50    AND b34=a16    AND a27=b16  AND a5=b41;
    
    takes 30 minutes to reorder, and 15 seconds to run when reordering is disabled.
    MySQL runs the query in under a second, demonstrating that reordering can still massively improve performance if we can make the algorithm more efficient. But this is a good stopgap measure.
  • 2044: use session builder from harness in the server engine
    Small fixes for memory harness for enginetest:
    • use sessionBuilder from the harness instead of DefaultSessionBuilder
    • convert row result for SHOW queries

Closed Issues

  • 6611: Creating attribute with more than 64 character is allowed but causes error.
  • 6724: dolt merge doesn't produce deterministic hashes

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 3, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 3, 2023
Merged via the queue into Homebrew:master with commit 116a2b4 Oct 3, 2023
12 checks passed
@chenrui333 chenrui333 deleted the bump-dolt-1.18.0 branch January 22, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants