Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitoxide 0.36.0 #172490

Merged
merged 2 commits into from
May 22, 2024
Merged

gitoxide 0.36.0 #172490

merged 2 commits into from
May 22, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
### New Features
  • checkout respects options for core.protectHFS and core.protectNTFS.
    This also adds gitoxide.core.protectWindows as a way to enforce
    additional restrictions that are usually only available on Windows.

    Note that core.protectNFS is always enabled by default, just like
    it is in Git.

Bug Fixes

  • more robustness in the face of a trampling-herd of threads loading a single index.
    The motivating example is here: Sporadic test failure: scan::appmaker::scan_workflow_from_git_url praetorian-inc/noseyparker#179

    Previously, it was possible for a trampling herd of threads to consolidate the
    disk state. Most of them would be 'needs-init' threads which could notice that
    the initialization already happened, and just use that.

    But a thread might be late for the party and somehow manages to not get any
    newly loaded index, and thus tries to consolidate with what's on disk again.
    Then it would again determine no change, and return nothing, causing the caller
    to abort and not find objects it should find because it wouldn't see the index
    that it should have seen.

    The reason the thread got into this mess is that the 'is-load-ongoing' flagging
    was racy itself, so it would not wait for ongoing loads and just conclude nothing
    happened. An extra delay (by yielding) now assures it either seees the loading state
    and waits for it, sees the newly loaded indices.

    Note that this issue can be reproduced with:

    './target/release/gix -r repo-with-one-pack -t10 --trace odb stats --extra-header-lookup'
    

Commit Statistics

  • 6 commits contributed to the release over the course of 10 calendar days.
  • 38 days passed between releases.
  • 2 commits were understood as conventional.
  • 0 issues like '(#ID)' were seen in commit messages

Commit Details

view details
  • Uncategorized
    • Merge branch 'various-fixes' (d6cd449)
    • Merge pull request from GHSA-7w47-3wg8-547c (79dce79)
    • Checkout respects options for core.protectHFS and core.protectNTFS. (886d6b5)
    • Mark safety-related core-flags as planned (f3d5a69)
    • Merge branch 'status' (04ef31e)
    • More robustness in the face of a trampling-herd of threads loading a single index. (addf446)

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels May 22, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 012864c May 22, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-gitoxide-0.36.0 branch May 22, 2024 17:59
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants