Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tartufo: update to use pygit2 1.15.1 #177628

Merged
merged 2 commits into from
Jul 18, 2024
Merged

tartufo: update to use pygit2 1.15.1 #177628

merged 2 commits into from
Jul 18, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

followup #166767

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Jul 17, 2024
@chenrui333
Copy link
Member Author

    File "/home/linuxbrew/.linuxbrew/Cellar/tartufo/5.0.0_3/libexec/lib/python3.12/site-packages/tartufo/util.py", line 305, in extract_commit_metadata
      "commit_hash": commit.hex,
                     ^^^^^^^^^^
  AttributeError: '_pygit2.Commit' object has no attribute 'hex'

@chenrui333 chenrui333 added test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 17, 2024
@chenrui333 chenrui333 removed test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 17, 2024
@carlocab
Copy link
Member

We should just use the pygit2 formula here. We have that so that formulae that use pygit2 don't need to be recompiled whenever libgit2 is updated.

Formula/t/tartufo.rb Outdated Show resolved Hide resolved
Signed-off-by: Rui Chen <rui@chenrui.dev>

tartufo: add pygit 1.15.1 build patch

Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 17, 2024
@branchvincent branchvincent removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 17, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 18, 2024
Merged via the queue into master with commit cc47258 Jul 18, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the tartufo-update branch July 18, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants