Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator-sdk (unpin go@1.21) #178113

Closed
wants to merge 1 commit into from
Closed

operator-sdk (unpin go@1.21) #178113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Formula/o/operator-sdk.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
sha256 cellar: :any_skip_relocation, x86_64_linux: "8102410241e3ef5ff368f5da37cf2f1a200ff891cf2ba060bf54b49c0571e68c"
end

# use "go" again when https://github.com/operator-framework/operator-sdk/issues/6644 is resolved and released
depends_on "go@1.21"
depends_on "go"

def install
ENV["GOBIN"] = bin
Expand All @@ -32,9 +31,7 @@
generate_completions_from_executable(bin/"operator-sdk", "completion")
end

test do

Check failure on line 34 in Formula/o/operator-sdk.rb

View workflow job for this annotation

GitHub Actions / Linux

`brew test --verbose operator-sdk` failed on Linux! 

/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4/bin/bundle clean
==> Testing operator-sdk
==> /home/linuxbrew/.linuxbrew/Cellar/operator-sdk/1.35.0/bin/operator-sdk version
==> /home/linuxbrew/.linuxbrew/Cellar/operator-sdk/1.35.0/bin/operator-sdk init --domain=example.com --repo=github.com/example/memcached
time="2024-07-22T17:14:51Z" level=info msg="Writing kustomize manifests for you to edit..."
time="2024-07-22T17:14:51Z" level=info msg="Writing scaffold for you to edit..."
time="2024-07-22T17:14:51Z" level=info msg="Get controller runtime:\n$ go get sigs.k8s.io/controller-runtime@v0.16.3"
go: downloading k8s.io/apimachinery v0.28.3
go: downloading k8s.io/client-go v0.28.3
go: downloading k8s.io/utils v0.0.0-20230406110748-d93618cff8a2
go: downloading github.com/go-logr/logr v1.2.4
go: downloading k8s.io/api v0.28.3
go: downloading k8s.io/klog/v2 v2.100.1
go: downloading sigs.k8s.io/structured-merge-diff/v4 v4.2.3
go: downloading k8s.io/component-base v0.28.3
go: downloading golang.org/x/net v0.17.0
go: downloading github.com/imdario/mergo v0.3.6
go: downloading golang.org/x/term v0.13.0
go: downloading golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e
go: downloading github.com/prometheus/client_golang v1.16.0
go: downloading k8s.io/apiextensions-apiserver v0.28.3
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9
go: downloading github.com/golang/protobuf v1.5.3
go: downloading golang.org/x/oauth2 v0.8.0
go: downloading golang.org/x/time v0.3.0
go: downloading github.com/google/uuid v1.3.0
go: downloading golang.org/x/sys v0.13.0
go: downloading github.com/fsnotify/fsnotify v1.6.0
go: downloading github.com/prometheus/client_model v0.4.0
go: downloading github.com/prometheus/common v0.44.0
go: downloading google.golang.org/protobuf v1.30.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/google/go-cmp v0.5.9
go: downloading github.com/prometheus/procfs v0.10.1
go: downloading golang.org/x/text v0.13.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading github.com/go-openapi/swag v0.22.3
go: downloading google.golang.org/appengine v1.6.7
time="2024-07-22T17:14:55Z" level=info msg="Update dependencies:\n$ go mod tidy"
go: downloading github.com/onsi/ginkgo/v2 v2.11.0
go: downloading github.com/onsi/gomega v1.27.10
go: downloading github.com/stretchr/testify v1.8.2
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading go.uber.org/goleak v1.2.1
go: downloading gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c
go: downloading github.com/kr/pretty v0.3.1
go: downloading github.com/rogpeppe/go-internal v1.10.0
go: downloading golang.org/x/tools v0.9.3
go: downloading github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1
go: downloading golang.org/x/mod v0.10.0
go: downloading github.com/benbjohnson/clock v1.3.0
==> /home/linuxbrew/.linuxbrew/Cellar/operator-sdk/1.35.0/bin/operator-sdk create api --group c --version v1 --kind M --resource --controller
time="2024-07-22T17:14:56Z" level=info msg="Writing kustomize manifests for you to edit..."
time="2024-07-22T17:14:56Z" level=info msg="Writing scaffold for you to edit..."
time="2024-07-22T17:14:56Z" level=info msg=api/v1/m_types.go
time="2024-07-22T17:14:56Z" level=info msg=api/v1/groupversion_info.go
time="2024-07-22T17:14:56Z" level=info msg=internal/controller/suite_test.go
time="2024-07-22T17:14:56Z" level=info msg=internal/controller/m_controller.go
time="2024-07-22T17:14:56Z" level=info msg=internal/controller/m_controller_test.go
time="2024-07-22T17:14:56Z" level=info msg="Update dependencies:\n$ go mod tidy"
time="2024-07-22T17:14:56Z" level=info msg="Running make:\n$ make generate"
go: downloading sigs.k8s.io/controller-tools v0.13.0
go: downloading github.com/spf13/cobra v1.7.0
go: downloading k8s.io/apiextensions-apiserver v0.28.0
go: downloading k8s.io/apimachinery v0.28.0
go: downloading golang.org/x/tools v0.12.0
go: downloading k8s.io/api v0.28.0
go: downloading golang.org/x/sys v0

Check failure on line 34 in Formula/o/operator-sdk.rb

View workflow job for this annotation

GitHub Actions / macOS 14-arm64

`brew test --verbose operator-sdk` failed on macOS Sonoma (14) on Apple Silicon! 

/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4/bin/bundle clean
==> Testing operator-sdk
==> /opt/homebrew/Cellar/operator-sdk/1.35.0/bin/operator-sdk version
==> /opt/homebrew/Cellar/operator-sdk/1.35.0/bin/operator-sdk init --domain=example.com --repo=github.com/example/memcached
INFO[0000] Writing kustomize manifests for you to edit... 
INFO[0000] Writing scaffold for you to edit...          
INFO[0000] Get controller runtime:
$ go get sigs.k8s.io/controller-runtime@v0.16.3 
go: downloading k8s.io/apimachinery v0.28.3
go: downloading github.com/go-logr/logr v1.2.4
go: downloading k8s.io/client-go v0.28.3
go: downloading k8s.io/klog/v2 v2.100.1
go: downloading k8s.io/utils v0.0.0-20230406110748-d93618cff8a2
go: downloading k8s.io/api v0.28.3
go: downloading sigs.k8s.io/structured-merge-diff/v4 v4.2.3
go: downloading k8s.io/apiextensions-apiserver v0.28.3
go: downloading k8s.io/component-base v0.28.3
go: downloading golang.org/x/net v0.17.0
go: downloading github.com/imdario/mergo v0.3.6
go: downloading golang.org/x/term v0.13.0
go: downloading golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e
go: downloading github.com/prometheus/client_golang v1.16.0
go: downloading k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9
go: downloading github.com/golang/protobuf v1.5.3
go: downloading golang.org/x/time v0.3.0
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading golang.org/x/oauth2 v0.8.0
go: downloading golang.org/x/sys v0.13.0
go: downloading github.com/google/uuid v1.3.0
go: downloading github.com/fsnotify/fsnotify v1.6.0
go: downloading github.com/prometheus/client_model v0.4.0
go: downloading github.com/prometheus/common v0.44.0
go: downloading google.golang.org/protobuf v1.30.0
go: downloading github.com/google/go-cmp v0.5.9
go: downloading github.com/prometheus/procfs v0.10.1
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading github.com/go-openapi/swag v0.22.3
go: downloading golang.org/x/text v0.13.0
go: downloading google.golang.org/appengine v1.6.7
INFO[0003] Update dependencies:
$ go mod tidy           
go: downloading github.com/onsi/gomega v1.27.10
go: downloading github.com/onsi/ginkgo/v2 v2.11.0
go: downloading github.com/stretchr/testify v1.8.2
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading go.uber.org/goleak v1.2.1
go: downloading gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c
go: downloading golang.org/x/tools v0.9.3
go: downloading github.com/kr/pretty v0.3.1
go: downloading github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1
go: downloading github.com/rogpeppe/go-internal v1.10.0
go: downloading golang.org/x/mod v0.10.0
go: downloading github.com/benbjohnson/clock v1.3.0
==> /opt/homebrew/Cellar/operator-sdk/1.35.0/bin/operator-sdk create api --group c --version v1 --kind M --resource --controller
INFO[0000] Writing kustomize manifests for you to edit... 
INFO[0000] Writing scaffold for you to edit...          
INFO[0000] api/v1/m_types.go                            
INFO[0000] api/v1/groupversion_info.go                  
INFO[0000] internal/controller/suite_test.go            
INFO[0000] internal/controller/m_controller.go          
INFO[0000] internal/controller/m_controller_test.go     
INFO[0000] Update dependencies:
$ go mod tidy           
INFO[0000] Running make:
$ make generate                
go: downloading sigs.k8s.io/controller-tools v0.13.0
go: downloading github.com/spf13/cobra v1.7.0
go: downloading k8s.io/apiextensions-apiserver v0.28.0
go: downloading k8s.io/apimachinery v0.28.0
go: downloading golang.org/x/tools v0.12.0
go: downloading k8s.io/api v0.28.0
go: downloading golang.org/x/sys v0.11.0
go: downloading golang.org/x/net v0.14.0
go: downloading golang.org/x/mod v0.12.0
go: downloading golang.org/x/text v0.12.0
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
ENV.prepend_path "PATH", Formula["go@1.21"].bin

if build.stable?
version_output = shell_output("#{bin}/operator-sdk version")
assert_match "version: \"v#{version}\"", version_output
Expand Down
Loading