Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-cli: migrate to python@3.12 #180221

Closed
wants to merge 1 commit into from

Conversation

luckman212
Copy link

azure-cli (az) now supports Python 3.12 (see Azure/azure-cli#2946).

This is the only formula on my system still remaining that requires 3.11 so it would be nice to finally update.

I built and tested this on macOS 14.6. This is my first such submission. I fumbled a bit with the steps to fork, update and submit this PR, so my sincere apologies if I did something incorrectly.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Aug 6, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 6, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title update azure-cli.rb formula to support Python 3.12 azure-cli: migrate to python@3.12 Aug 6, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Aug 6, 2024
@carlocab
Copy link
Member

carlocab commented Aug 6, 2024

Thanks! Upstream have some automation that will remove this change at their next release, though, so corresponding changes need to be made there as well.

See Azure/azure-cli#23788 for an example.

@luckman212
Copy link
Author

Ok @carlocab so just confirming, nothing else I need to do here, we are waiting for an upstream bump?

@branchvincent
Copy link
Member

hey @bebound, I see you recently closed Azure/azure-cli#27673 but Azure/azure-cli#27196 and Azure/azure-cli#28829 are still open. Is azure-cli ready for 3.12?

@bebound
Copy link
Contributor

bebound commented Aug 7, 2024

These two issues need to be fixed before we bump the bundled Python to 3.12.
I'll update the formula then.

@carlocab
Copy link
Member

carlocab commented Aug 7, 2024

Looks like this isn't ready just yet. Thanks for the PR anyway, @luckman212!

@carlocab carlocab closed this Aug 7, 2024
@carlocab carlocab added upstream issue An upstream issue report is needed and removed ready to merge PR can be merged once CI is green labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python use is a significant feature of the PR or issue python-3.12-migration rust Rust use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants