-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gleam
+rebar3
+erlang_ls
: depend on erlang@26
#191441
gleam
+rebar3
+erlang_ls
: depend on erlang@26
#191441
Conversation
erlang_ls
+gleam
+rebar3
: depend on erlang@26
b1b8f46
to
8bc85bf
Compare
8bc85bf
to
541f769
Compare
541f769
to
9408e74
Compare
9408e74
to
a829dca
Compare
erlang_ls
+gleam
+rebar3
: depend on erlang@26
gleam
+rebar3
: depend on erlang@26
gleam
+rebar3
: depend on erlang@26
gleam
+rebar3
+erlang_ls
: depend on erlang@26
As a pre-condition/dependency for gleam Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Because `gleam` does: - this forces `rebar3` to - this forces `erlang_ls` to Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
c05a7dc
to
0bbb43e
Compare
🤖 An automated task has requested bottles to be published to this PR. |
@@ -4,6 +4,7 @@ class Gleam < Formula | |||
url "https://github.com/gleam-lang/gleam/archive/refs/tags/v1.5.0.tar.gz" | |||
sha256 "0342babfbd6d8201ae00b6b0ef5e0b181bce5690c703ffae8dd02542e024c4c2" | |||
license "Apache-2.0" | |||
revision 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this about? (for my education for potential future pull requests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that pre-existing gleam
installs should now be considered outdated, which avoids their getting broken when erlang
gets upgraded to Erlang 27 (because pre-existing gleam
installs are still configured to use the erlang
formula and not erlang@26
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
@carlocab, I wanna tackle an issue I think In other words if you try to use Do you think this is resolvable by script? e.g. fetching as a dependency (I can open an issue, otherwise, for follow-up) |
A mix of both. See #191485. |
We're pining
rebar3
toerlang@26
at this moment (because ofgleam
), since we're getting ready forerlang@27
, not supported by the former.Reasoning:
gleam
doesn't work with OTP 27 yet (?) - I'm not certain of this, at this moment, because the ecosystem moves fast, but I'll keep my eye out for updates.Further considerations
It's not that
rebar3
itself needs to depend onerlang@26
(it should build fine witherlang
, orerlang@27
). It's thatgleam
depends onrebar3
and thus we have a mismatch in dependencies which CI complains about. And then we need to updateerlang_ls
lest we get another mismatch.gleam
: Have you built your formula locally withHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?rebar3
: Have you built your formula locally withHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?erlang_ls
: Have you built your formula locally withHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?gleam
: Is your test running finebrew test <formula>
, where<formula>
is the name of the formula you're submitting?rebar3
: Is your test running finebrew test <formula>
, where<formula>
is the name of the formula you're submitting?erlang_ls
: Is your test running finebrew test <formula>
, where<formula>
is the name of the formula you're submitting?gleam
: Does your build passbrew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?rebar3
: Does your build passbrew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?erlang_ls
: Does your build passbrew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?