Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alot,gpgme,notmuch: migrate to python@3.13 #194547

Merged
merged 6 commits into from
Nov 10, 2024
Merged

alot,gpgme,notmuch: migrate to python@3.13 #194547

merged 6 commits into from
Nov 10, 2024

Conversation

chenrui333
Copy link
Member

notmuch: migrate to python@3.13

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Oct 16, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Oct 16, 2024
@branchvincent
Copy link
Member

need to also migrate alot

@chenrui333 chenrui333 changed the title notmuch: migrate to python@3.13 alot,gpgme,notmuch: migrate to python@3.13 Oct 16, 2024
@chenrui333
Copy link
Member Author

  ==> /opt/homebrew/opt/notmuch/bin/notmuch new
  Found 0 total files (that's not much mail).
  No new mail.
  Error: alot: failed
  An exception occurred within a child process:
    Minitest::Assertion: out.log file should exist.
  Expected #<Pathname:/private/tmp/alot-test-20241015-65978-syo3nu/out.log> to be exist?.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 16, 2024
@chenrui333
Copy link
Member Author

chenrui333 commented Oct 21, 2024

mailcap module got removed in py3.13, upstream issue, pazz/alot#1632


$ alot --version
Traceback (most recent call last):
  File "/opt/homebrew/bin/alot", line 5, in <module>
    from alot.__main__ import main
  File "/opt/homebrew/Cellar/alot/0.11_1/libexec/lib/python3.13/site-packages/alot/__main__.py", line 11, in <module>
    from alot.settings.const import settings
  File "/opt/homebrew/Cellar/alot/0.11_1/libexec/lib/python3.13/site-packages/alot/settings/const.py", line 4, in <module>
    from .manager import SettingsManager
  File "/opt/homebrew/Cellar/alot/0.11_1/libexec/lib/python3.13/site-packages/alot/settings/manager.py", line 7, in <module>
    import mailcap
ModuleNotFoundError: No module named 'mailcap'

@chenrui333 chenrui333 closed this Oct 21, 2024
@chenrui333 chenrui333 added upstream issue An upstream issue report is needed test failure CI fails while running the test-do block labels Oct 21, 2024
@chenrui333 chenrui333 deleted the notmuch-py3.13 branch October 21, 2024 15:46
@branchvincent branchvincent restored the notmuch-py3.13 branch November 9, 2024 20:22
@branchvincent branchvincent reopened this Nov 9, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 9, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@branchvincent branchvincent added ready to merge PR can be merged once CI is green and removed upstream issue An upstream issue report is needed test failure CI fails while running the test-do block automerge-skip `brew pr-automerge` will skip this pull request labels Nov 9, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 10, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 10, 2024
Merged via the queue into master with commit e0ced7b Nov 10, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the notmuch-py3.13 branch November 10, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue python-3.13-migration ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants