-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mariadb-connector-c: make keg_only #196747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho-m
force-pushed
the
mariadb-connector-c-keg-only
branch
2 times, most recently
from
November 5, 2024 21:33
66a003e
to
cf385d1
Compare
cho-m
force-pushed
the
mariadb-connector-c-keg-only
branch
from
November 5, 2024 21:50
cf385d1
to
650c6e3
Compare
cho-m
added
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
labels
Nov 5, 2024
cho-m
force-pushed
the
mariadb-connector-c-keg-only
branch
2 times, most recently
from
November 8, 2024 02:26
831c58b
to
3222759
Compare
cho-m
added
maintainer feedback
Additional maintainers' opinions may be needed
automerge-skip
`brew pr-automerge` will skip this pull request
labels
Nov 8, 2024
cho-m
force-pushed
the
mariadb-connector-c-keg-only
branch
from
November 8, 2024 05:54
3222759
to
04094ef
Compare
github-actions
bot
removed
the
automerge-skip
`brew pr-automerge` will skip this pull request
label
Nov 8, 2024
carlocab
approved these changes
Nov 8, 2024
daeho-ro
approved these changes
Nov 9, 2024
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
label
Nov 9, 2024
tobil4sk
added a commit
to tobil4sk/neko
that referenced
this pull request
Nov 25, 2024
This brew package is now keg-only so we need to link it explicitly for it to be symlinked into accessible paths. Homebrew/homebrew-core#196747
Simn
pushed a commit
to HaxeFoundation/neko
that referenced
this pull request
Nov 25, 2024
* [ci] Fix pkgconf package conflict * Link mariadb-connector-c in homebrew install This brew package is now keg-only so we need to link it explicitly for it to be symlinked into accessible paths. Homebrew/homebrew-core#196747 * [ci] Remove verbose flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
long build
Set a long timeout for formula testing
maintainer feedback
Additional maintainers' opinions may be needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mariadb-connector-c
changes:keg_only
- to remove conflicts and allow installing at same time asmariadb
. This imitatesmysql-client
.zstd
everywhere to align Linux/macOS dep tree and matchmysql-client
featureWITH_OPENSSL
,OPENSSL_INCLUDE_DIR
,COMPILATION_COMMENT
)-DINSTALL_LIBDIR=#{lib}
to simplify Linux RPATH (otherwise dependents will need extra RPATH to#{lib}/mariadb
). For backwards compatibility, add symlinks for shared libs that users may have linked to.-DWITH_MYSQLCOMPAT=ON
to simplify dependent builds. Particularly helps avoid accidentally linking to staticlibmariadbclient.a
since MariaDB does not providelibmariadbclient.{so,dylib}
symlink and some formulae search formariadbclient
beforemariadb
.mysql_config
symlink to simplify dependent builds as some old formulae don't look formariadb_config
too.Going to also experiment with switching formulae to MariaDB library given:
zlib
whereas MySQL propagates brewzlib
(due to-lz
getting passed to dependents)mysql-client
.MariaDB libraries has gotten decent testing in other repositories, e.g. a lot of Linux distros (e.g. Arch, Debian, Fedora) switched many years ago due to worry about Oracle open-source support (though this never became a problem).
The formulae that use
DBD::mysql
may still need amysql-client
dependency as v5 claims to use some features from that variant. Arch and Debian have keptDBD::mysql
v4 to deal with this while Fedora added dependency for MySQL 8.0This impacts:
innotop
percona-toolkit
percona-xtrabackup