Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php 8.4.1 php@8.3 8.3.14 (new formula) #198473

Merged
merged 12 commits into from
Nov 22, 2024
Merged

php 8.4.1 php@8.3 8.3.14 (new formula) #198473

merged 12 commits into from
Nov 22, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Nov 21, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 21, 2024
@chenrui333 chenrui333 marked this pull request as draft November 21, 2024 14:20
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core autobump labels Nov 21, 2024
@chenrui333 chenrui333 changed the title php 8.4.1 php 8.4.1 php@8.3 8.3.14 (new formula) Nov 21, 2024
@chenrui333 chenrui333 marked this pull request as ready for review November 21, 2024 14:30
@chenrui333
Copy link
Member 

  install: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/php.3/8.3.14/lib/httpd/libphp.so': No such file or directory
  apxs:Error: Command failed with rc=65536
  .
  make: *** [Makefile:194: install-sapi] Error 1
  make: *** Waiting for unfinished jobs....

@github-actions github-actions bot removed new formula PR adds a new formula to Homebrew/homebrew-core autobump labels Nov 21, 2024
@chenrui333 chenrui333 changed the title php 8.4.1 php@8.3 8.3.14 (new formula) php 8.4.1 Nov 21, 2024
@chenrui333 chenrui333 added php PHP use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 21, 2024
@chenrui333 chenrui333 mentioned this pull request Nov 21, 2024
Closed
2 tasks
@chenrui333 chenrui333 changed the title php 8.4.1 php 8.4.1 php@8.3 8.3.14 (new formula) Nov 21, 2024
@chenrui333 chenrui333 removed the ready to merge PR can be merged once CI is green label Nov 21, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core autobump and removed php PHP use is a significant feature of the PR or issue labels Nov 21, 2024
@chenrui333 chenrui333 added php PHP use is a significant feature of the PR or issue and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 21, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request and removed php PHP use is a significant feature of the PR or issue labels Nov 21, 2024
@SMillerDev
Copy link
Member

Psalm support is tracked here: vimeo/psalm#11107

BrewTestBot and others added 2 commits November 21, 2024 19:46
@BrewTestBot @chenrui333
php 8.4.1
2c5a8d5 
php: update build patches

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
php@8.3 8.3.14 (new formula)
cc5d66f 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
deployer: use php@8.3
0740450 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
php-cs-fixer: use php@8.3
0bec41d 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
phpmyadmin: update to use php@8.3 for test
ca2363b 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
psalm: use php@8.3
3fb521e 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Member

chenrui333 commented Nov 22, 2024 •
edited
Loading

deploy's php 8.4 support, deployphp/deployer#3958

@chenrui333 chenrui333 mentioned this pull request Nov 22, 2024
Open
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit e395ba7 Nov 22, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-php-8.4.1 branch November 22, 2024 14:43
@ruudk
Copy link
Contributor

ruudk commented Nov 22, 2024

Thanks for this!

Not sure if this was intended, but I had installed php via brew install php@8.3 before this change. And now that was upgraded to PHP 8.4.1. I had to manually run brew install php@8.3 again to get my older version back.

@chenrui333
Copy link
Member

Not sure if this was intended, but I had installed php via brew install php@8.3 before this change. And now that was upgraded to PHP 8.4.1. I had to manually run brew install php@8.3 again to get my older version back.

yeah, that is intended, php@8.3 was an alias to php before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
autobump bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrewTestBot @chenrui333 @SMillerDev @ruudk