-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua 5.3.4, rename from lua@5.3 and lua@5.1: add unversioned pkg-config file #21300
Changes from all commits
441738f
de9ac72
322fb0c
602c62f
405f8c7
8e3ce87
9fffcd1
47cac07
2ccdc57
1daae43
ca34dd2
67919d1
49c2603
d82bbe0
8d15b90
a636310
a1496ab
d6ccbd2
4c80c07
fe4c157
3764d07
1fb8bcf
6a85681
1eea86b
981b14c
04291fa
4f4f09a
8d2bcc2
5f71f2a
6d830e9
f52bbec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ class Httest < Formula | |
homepage "https://htt.sourceforge.io/" | ||
url "https://downloads.sourceforge.net/project/htt/htt2.4/httest-2.4.23/httest-2.4.23.tar.gz" | ||
sha256 "52a90c9719b35226ed1e26a5262df0d14aeb63b258187656bf1eb30ace53232c" | ||
revision 1 | ||
|
||
bottle do | ||
cellar :any | ||
|
@@ -15,11 +16,17 @@ class Httest < Formula | |
depends_on "apr-util" | ||
depends_on "openssl" | ||
depends_on "pcre" | ||
depends_on "lua" => :recommended | ||
depends_on "lua@5.1" => :recommended | ||
depends_on "nghttp2" => :recommended | ||
depends_on "spidermonkey" => :recommended | ||
|
||
deprecated_option "without-lua" => "without-lua@5.1" | ||
|
||
def install | ||
inreplace "configure", | ||
"else LUA_LIB_PATH=\"-L${withval}\"; LUA_INCLUDES=\"-I${withval}\"; LUA_LIB=\"-llua\"; fi", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They've hardcoded expecting a vanilla There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's gibberish. Notice they expect to find the library and the includes in the exact same directory without taking into account include vs. lib subdirectories. Here's how it searches:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is... that is special. |
||
"else LUA_LIB_PATH=\"-L${withval}/lib\"; LUA_INCLUDES=\"-I${withval}/include/lua-5.1\"; LUA_LIB=\"-llua.5.1\"; fi" | ||
|
||
# Fix "fatal error: 'pcre/pcre.h' file not found" | ||
# Reported 9 Mar 2017 https://sourceforge.net/p/htt/tickets/4/ | ||
(buildpath/"brew_include").install_symlink Formula["pcre"].opt_include => "pcre" | ||
|
@@ -36,8 +43,9 @@ def install | |
"--enable-html-module", | ||
"--enable-xml-module", | ||
"--with-apr=#{Formula["apr"].opt_bin}", | ||
"--with-lua=#{Formula["lua@5.1"].opt_prefix}", | ||
] | ||
args << "--enable-lua-module" if build.with? "lua" | ||
args << "--enable-lua-module" if build.with? "lua@5.1" | ||
args << "--enable-h2-module" if build.with? "nghttp2" | ||
args << "--enable-js-module" if build.with? "spidermonkey" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this double checked locally on a system that has multiple versions of Lua installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(CMake being CMake has the tendency to do whatever the hell it likes, even when passed direct variables in some cases, because life is fun 🙃)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.