Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-backend-git 0.0.13 (new formula) #55511

Closed
wants to merge 17 commits into from
Closed

terraform-backend-git 0.0.13 (new formula) #55511

wants to merge 17 commits into from

Conversation

dee-kryvenko
Copy link

@dee-kryvenko dee-kryvenko commented May 30, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@dee-kryvenko dee-kryvenko changed the title Add tf git backend terraform-backend-git 0.0.13 (new formula) May 30, 2020
@chenrui333 chenrui333 added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels May 30, 2020
@dee-kryvenko
Copy link
Author

@chenrui333 I think I fixed all tests failures and accounted for your feedback. Seems like it's failing due to the repository is "not notable enough".

I understand why there is such a requirement and if you refuse to merge, I'll understand.

However, please consider the following - this Terraform HTTP backend implementation meant to be a part of hashicorp/terraform (notable enough, I think), as backends being a part of the core code base is the only options atm. Scalability issue with this approach is well understood by now, and they are going to make backends a pluggable bits hashicorp/terraform#5877. When it's done, backends will be discoverable and consumable by internal Terraform mechanisms, so terraform-backend-git will not need to be distributed as a separate binary via brew or else. Therefore, this formula (if accepted) will be having limited lifetime and expected to be deprecated at some point.

However, getting there might take quite a some time, and meanwhile I was hoping brew could help giving this project a spin in terms of discoverability and lowering the entrance barrier. Is there a chance for it?

@stale
Copy link

stale bot commented Jun 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Jun 21, 2020
@chenrui333
Copy link
Member

Hey @dee-kryvenko and thanks for the PR!

While this seems like pretty cool software, the audit failures mean it's not notable enough for us to package in Homebrew for now. This is not a decision on the merits of the software, but we cannot distribute every single piece of software and have to draw a line on "notability" somewhere. Of course, we would be happy to reconsider in the future.

Please consider hosting it in a personal tap, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@chenrui333 chenrui333 closed this Jun 21, 2020
@chenrui333
Copy link
Member

I am personally a terraform user and a SRE, will definitely try out your git backend (which seems very cool).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants