Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 7.2.0 #7167

Closed
wants to merge 1 commit into from
Closed

node 7.2.0 #7167

wants to merge 1 commit into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 23, 2016

Created with brew bump-formula-pr.

@ilovezfs
Copy link
Contributor

Please try bumping the vendored npm to 4.0.2 as well.

@JLHwung
Copy link
Contributor Author

JLHwung commented Nov 23, 2016

@ilovezfs The upstream said node 7.2.0 is bundled with npm 3.10.9, shall we track upstream dependencies and keep npm as 3.10.9?

Quoted from @DomT4

We track what Node bundles upstream, unless what Node bundles upstream has security or major usability problems resolved in a newer release.

If we change the policy on node/npm, it shall also reflects on the formula comments. Personally I agree with Dom.

We track major/minor from upstream Node releases.
We will accept important npm patch releases when necessary.
Homebrew/legacy-homebrew#46098 (comment)

Edited: add personal opinion.

@DomT4
Copy link
Member

DomT4 commented Nov 23, 2016

I quit, so it's pretty much up to ILZ, but I think both Homebrew and Node upstream find more stability in tracking the Node version as much as possible. I've seen less complaints directed at Node/npm at least since we adopted that policy.

@ilovezfs
Copy link
Contributor

Sure 3.10.9 will be fine, though it's annoying since we don't have a separate npm formula and current stable npm is 4.0.2 not 3.10.9.

@josh18 josh18 mentioned this pull request Nov 25, 2016
@ilovezfs
Copy link
Contributor

@BrewTestBot test this please

@ilovezfs ilovezfs closed this in 5879ea5 Nov 25, 2016
@ilovezfs
Copy link
Contributor

@JLHwung thanks for your contribution to Homebrew!

@JLHwung
Copy link
Contributor Author

JLHwung commented Nov 26, 2016

@ilovezfs You're very welcome.

@JLHwung JLHwung deleted the node-7.2.0 branch November 26, 2016 02:18
@JLHwung
Copy link
Contributor Author

JLHwung commented Nov 26, 2016

@ilovezfs We might not see a npm@4 bundled release on v7 according to nodejs/node#9284 (comment). It is marked as semver-major and 8.0.0 milestone.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants