Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.51.0 #73924

Closed
wants to merge 2 commits into from
Closed

rust 1.51.0 #73924

wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Mar 25, 2021

action-homebrew-bump-formula


Created with brew bump-formula-pr.

resource blocks may require updates.

@carlocab
Copy link
Member

Killing the tests as they will probably need to be restarted anyway when Homebrew/brew#10934 is merged.

@bayandin
Copy link
Member

Failures on Apple Silicon:

Error: 71 failed steps!
brew install --build-from-source amp
brew install --build-from-source asuka
brew test --retry --verbose aws-google-auth
brew install --build-from-source bandwhich
brew install --build-from-source boringtun
brew install --build-from-source --only-dependencies caffe
brew install --build-from-source caffe
brew install --build-from-source cargo-instruments
brew test --retry --verbose chromaprint
brew install --build-from-source chronograf
brew install --build-from-source click
brew install --build-from-source dartsim
brew install --build-from-source --only-dependencies dog
brew install --build-from-source dog
brew install --build-from-source dprint
brew install --build-from-source --only-dependencies efl
brew install --build-from-source efl
brew install --build-from-source fblog
brew test --retry --verbose ffmpegthumbnailer
brew install --build-from-source ffsend
brew test --retry --verbose fnm
brew install --build-from-source gifski
brew install --build-from-source git-trim
brew install --build-from-source --only-dependencies gitg
brew install --build-from-source gitg
brew install --build-from-source gjs
brew install --build-from-source gleam
brew install --build-from-source --only-dependencies gnuradio
brew install --build-from-source gnuradio
brew install --build-from-source grin
brew install --build-from-source grin-wallet
brew test --retry --verbose ktmpl
brew test --retry --verbose libgit2-glib
brew test --retry --verbose mat2
brew install --build-from-source miniserve
brew install --build-from-source --only-dependencies mlpack
brew install --build-from-source mlpack
brew test --retry --verbose mlt
brew install --build-from-source mpv
brew install --build-from-source openalpr
brew test --retry --verbose openimageio
brew install --build-from-source --only-dependencies pandoc-plot
brew install --build-from-source pandoc-plot
brew install --build-from-source pdfpc
brew install --build-from-source --only-dependencies pushpin
brew install --build-from-source pushpin
brew install --build-from-source --only-dependencies qmmp
brew install --build-from-source qmmp
brew install --build-from-source rbspy
brew install --build-from-source ripgrep-all
brew install --build-from-source rm-improved
brew install --build-from-source rustscan
brew test --retry --verbose saltwater
brew install --build-from-source shadowenv
brew install --build-from-source silicon
brew install --build-from-source siril
brew install --build-from-source sniffglue
brew install --build-from-source sonic
brew install --build-from-source spotifyd
brew install --build-from-source ssh-permit-a38
brew install --build-from-source --only-dependencies synfig
brew install --build-from-source synfig
brew install --build-from-source vice
brew install --build-from-source volta
brew install --build-from-source wagyu
brew install --build-from-source wapm
brew install --build-from-source wasm-pack
brew install --build-from-source --only-dependencies xboard
brew install --build-from-source xboard
brew test --retry --verbose xdot
brew install --build-from-source zim

@carlocab
Copy link
Member

Most of the ARM failures don't have bottles. The ones that do are

aws-google-auth
cargo-instruments
chronograf
gifski
gleam
miniserve
mpv
siril
sniffglue

@carlocab
Copy link
Member

carlocab commented Mar 27, 2021

Big Sur:

Error: 15 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose asuka
brew test --retry --verbose aws-google-auth
brew install --build-from-source chronograf
brew install --build-from-source dartsim
brew install --build-from-source gifski
brew install --build-from-source gleam
brew test --retry --verbose ktmpl
brew install --build-from-source miniserve
brew install --build-from-source pdfpc
brew install --build-from-source siril
brew install --build-from-source sniffglue
brew install --build-from-source vice
brew test --retry --verbose wasm-pack
brew test --retry --verbose wasm-pack

Catalina:

Error: 14 failed steps!
brew test --retry --verbose aws-google-auth
brew test --retry --verbose aws-google-auth
brew install --build-from-source chronograf
brew install --build-from-source dartsim
brew install --build-from-source gifski
brew install --build-from-source gleam
brew test --retry --verbose ktmpl
brew install --build-from-source miniserve
brew install --build-from-source pdfpc
brew install --build-from-source siril
brew install --build-from-source sniffglue
brew install --build-from-source vice
brew test --retry --verbose wasm-pack
brew test --retry --verbose wasm-pack

Mojave:

Error: 12 failed steps!
brew install --build-from-source chronograf
brew install --build-from-source dartsim
brew install --build-from-source gifski
brew install --build-from-source gleam
brew test --retry --verbose ktmpl
brew install --build-from-source miniserve
brew install --build-from-source pdfpc
brew install --build-from-source siril
brew install --build-from-source sniffglue
brew install --build-from-source vice
brew test --retry --verbose wasm-pack
brew test --retry --verbose wasm-pack

We can ignore vice. That's from a vice dependency being unlinked earlier in the CI run but not being re-linked for the vice build.

Aside from a handful of exceptions, it looks like there's a lot of overlap between the failures on the four CI nodes. (At least, if you disregard the ARM failures that haven't been bottled yet.)

@Moisan
Copy link
Member

Moisan commented Mar 27, 2021

miniserve has been updated to 0.12.1 since the last CI run. I can build it successfully with rust 1.51.0 locally.

@Moisan
Copy link
Member

Moisan commented Mar 28, 2021

Gleam has been updated in #74039 and upstream changelog includes

The Gleam compiler has been updated to compile with the new Rust v1.51.0.

@Moisan
Copy link
Member

Moisan commented Mar 29, 2021

chronograf currently doesn't build on master. Its only dependency on rust is trough influxdb which builds correctly with rust 1.51.0 .

@carlocab
Copy link
Member

chronograf may need to be switched to influxdb@1.

@Bo98
Copy link
Member

Bo98 commented Mar 29, 2021

chronograf will be fixed in the next version: influxdata/chronograf@6532c63 (or at least the specific error shown in the CI). Not Rust related.

@Moisan
Copy link
Member

Moisan commented Mar 29, 2021

chronograf may need to be switched to influxdb@1

I tried locally and it leads to the same error.

@carlocab
Copy link
Member

I guess the only ones that still look suspicious (without double-checking the logs...) are gifski, sniffglue, dartsim, and pdfpc. I think the rest also failed in the Rust 1.50 bump.

@Bo98
Copy link
Member

Bo98 commented Mar 29, 2021

gifski has an open PR. I'll have a look at what's going wrong but it seems to not build on arm64 correctly.

sniffglue requires this patch: https://github.com/kpcyrd/sniffglue/commit/e2244ab2616272faa8ebce18308e146f275250c4.patch?full_index=1

dartsim actually broke from the CMake 3.20 update, which is a rare thing to see.

pdfpc broke with Vala 0.51.1.

@Moisan Moisan mentioned this pull request Mar 30, 2021
5 tasks
@carlocab
Copy link
Member

Actually, I just realised cargo-instruments and siril are unexpected. I think they're unrelated based on the logs though.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the failures are unrelated to this version bump. Merging.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@Bo98
Copy link
Member

Bo98 commented Mar 30, 2021

sniffglue isn't, but can be fixed after merge.

@carlocab
Copy link
Member

Oops. OK, will open a PR for sniffglue.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2021
@chenrui333 chenrui333 deleted the bump-rust-1.51.0 branch December 18, 2022 05:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants