Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc@7: split args for macOS and Linux #74930

Closed
wants to merge 1 commit into from
Closed

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Apr 10, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka iMichka added the linux to homebrew-core Migration of linuxbrew-core to homebrew-core label Apr 10, 2021
@BrewTestBot BrewTestBot added legacy Relates to a versioned @ formula missing license Formula has a missing license which should be added no ARM bottle Formula has no ARM bottle labels Apr 10, 2021
@carlocab
Copy link
Member

I think we want to merge this with bottles. Judging from the log, it looks like the Mojave bottle was built when the CLT on the Mojave runner was broken (we had the Catalina SDK installed instead), and hasn't been rebuilt since that was fixed.

That would explain this: Homebrew/discussions#1256

@iMichka
Copy link
Member Author

iMichka commented Apr 11, 2021

I'm fine with that. Should I revision-bump it?

@carlocab
Copy link
Member

Not sure. We haven't seen a complaint about it until now so I suspect it's not really needed. Still, I guess it doesn't hurt.

@iMichka
Copy link
Member Author

iMichka commented Apr 11, 2021

I bumped the revision.

Regarding the license, I'll do a separate PR for all the gcc versions later.

@carlocab
Copy link
Member

Ok. May as well rev-bump all the gcc PRs you have open that still build on our current runners. That's gcc 6, 8, and 9, I think.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label May 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Relates to a versioned @ formula linux to homebrew-core Migration of linuxbrew-core to homebrew-core missing license Formula has a missing license which should be added no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants