go 1.17 #83413

branchvincent · 2021-08-16T21:23:03Z

Created with brew bump-formula-pr.

~~resource blocks may require updates.~~

SMillerDev · 2021-08-17T16:39:31Z

Try building them with go 1.17 and fix them if they're broken.

roopakv · 2021-08-17T16:56:39Z

@SMillerDev some of them are flakes i guess, cos I got it to pass locally. and that is why I was confused

carlocab · 2021-08-17T17:48:01Z

You can help by trying to make the tests less flaky so they don't show up on the next Go PR, if you can.

samuel · 2021-08-17T23:02:00Z

A number of those failures seem to be related to golang/go#46763

Specifically the comment:

@marwan-at-work the golang.org/x/sys/unix.libc_ioctl_trampoline error looks like what was fixed as part of #45702. The fix on your end should be to update golang.org/x/sys to latest (it looks like you are on a version before the fix at golang/sys@a76c4d0).

Referring to golang/go#45702

carlocab · 2021-08-18T07:43:50Z

Big Sur failures are the same as on Mojave. Catalina failures are also the same except for orgalorg, which did not fail.

Updating x/sys so that this supports go 1.17. Once this is in here we will need to cut a new release. More context: Homebrew/homebrew-core#83413 See also ooni/probe#1737 Co-authored-by: Simone Basso <bassosimone@gmail.com>

Updating x/sys so that this supports go 1.17. Once this is in here we will need to cut a new release. More context: Homebrew/homebrew-core#83413 See also ooni/probe#1737 Co-authored-by: Simone Basso <bassosimone@gmail.com> This is a cherry-pick of 143949a Conflicts: go.mod

roopakv · 2021-08-18T21:55:29Z

blacktop · 2021-08-19T02:19:11Z

Would it be possible for you all to kind of pin previous versions of Golang? Like brew install go1.16 and then all these packages that depend on Go can pin to a version and not hold up the release of NEW versions? #askingforafriendwholovesbrewandrunninglatestgoasap 😏

carlocab · 2021-08-26T08:55:10Z

Also, CC @codefromthecrypt for envoy and envoy@1.18 build failures on Big Sur.

codefromthecrypt · 2021-08-26T21:11:18Z

I will try the envoy ones locally (as I have Big Sur) and try to help triage upstream as necessary

branchvincent · 2021-08-26T21:35:16Z

both envoy failures seems unrelated:

fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: can't write to output file (No space left on device)

codefromthecrypt · 2021-08-26T21:42:15Z

@mattklein123

The problem here is that go can't be upgraded until all things that depend on it can. The impact is that end users can't install go 1.17

While there are other projects blocking this, Envoy is also. Specifically, homebrew builds the envoy 1.19 and 1.18 latest version, and they don't work with go 1.17.

IIUC, there is some part of how Envoy uses protos that ends up requiring go. @keith or maybe @phlax will know better. I don't personally have the experience to know exactly what is going on and how to fix it.

Once this is sorted, whatever is implied to make this work would ideally be cherry-picked into these branches so that patches aren't needed forever.

PS I opened this some time back as I noticed in general the Envoy team are unaware of homebrew. At least raising a PR during a release will help keep folks on the project team aware of knock-on effects on ecosystems mentioned in the install page. envoyproxy/envoy#17500

Hope this helps!

codefromthecrypt · 2021-08-26T22:14:23Z

Here's how I will verify on amd64 and arm64 Big Sur:

$ cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core
$ gh pr checkout 83413
$ brew install --build-from-source go
$ brew install --build-from-source envoy

codefromthecrypt · 2021-08-26T22:18:32Z

revised my comment, can skip the remote bottle download by brew install --build-from-source go first

codefromthecrypt · 2021-08-26T22:47:29Z

here's the failure on envoy with Big Sur arm64 (M1). amd64 is still chugging

==> /opt/homebrew/opt/bazelisk/bin/bazelisk build --compilation_mode=opt --curses=no --show_task_finish 
Last 15 lines from /Users/thebots/Library/Logs/Homebrew/envoy/01.bazelisk:
ERROR: An error occurred during the fetch of repository 'go_sdk':
   Traceback (most recent call last):
	File "/private/tmp/envoy-20210827-59011-735pgh/.brew_home/_bazel/6734651a1108d63ae9e743df04c9a20c/external/io_bazel_rules_go/go/private/sdk.bzl", line 98, column 13, in _go_download_sdk_impl
		fail("unsupported platform {}".format(platform))
Error in fail: unsupported platform darwin_arm64
ERROR: Error fetching repository: Traceback (most recent call last):
	File "/private/tmp/envoy-20210827-59011-735pgh/.brew_home/_bazel/6734651a1108d63ae9e743df04c9a20c/external/io_bazel_rules_go/go/private/sdk.bzl", line 98, column 13, in _go_download_sdk_impl
		fail("unsupported platform {}".format(platform))
Error in fail: unsupported platform darwin_arm64
ERROR: Analysis of target '//source/exe:envoy-static' failed; build aborted: unsupported platform darwin_arm64
INFO: Elapsed time: 83.843s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (18 packages loaded, 7 targets configured)
FAILED: Build did NOT complete successfully (18 packages loaded, 7 targets configured)

keith · 2021-08-26T23:52:25Z

Best to ignore M1 support for Envoy atm until envoyproxy/envoy#16482 is resolved

codefromthecrypt · 2021-08-27T00:35:41Z

On darwin/amd64 building envoy local worked, so it may indeed be a transient or worker related issue

± |bump-go-1.17 {1} ✓| → brew install --build-from-source envoy
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
==> New Formulae
airspyhf

==> Downloading https://github.com/envoyproxy/envoy/commit/3b49166dc0841b045799e
Already downloaded: /Users/adrian/Library/Caches/Homebrew/downloads/9cc321c489d93019439b089e49a1221bfcdc27016debe90f699e20737b667c3d--3b49166dc0841b045799e2c37bdf1ca9de98d5b1.patch
==> Cloning https://github.com/envoyproxy/envoy.git
Updating /Users/adrian/Library/Caches/Homebrew/envoy--git
==> Checking out tag v1.19.0
HEAD is now at 68fe53a88 release: v1.19.0 (#17320)
HEAD is now at 68fe53a88 release: v1.19.0 (#17320)
==> Patching
==> Applying 3b49166dc0841b045799e2c37bdf1ca9de98d5b1.patch
patching file bazel/envoy_internal.bzl
==> /usr/local/opt/bazelisk/bin/bazelisk build --compilation_mode=opt --curses=n
🍺  /usr/local/Cellar/envoy/1.19.0: 319 files, 118.9MB, built in 68 minutes 35 seconds

lizan · 2021-08-27T02:52:13Z

here's the failure on envoy with Big Sur arm64 (M1). amd64 is still chugging

==> /opt/homebrew/opt/bazelisk/bin/bazelisk build --compilation_mode=opt --curses=no --show_task_finish 
Last 15 lines from /Users/thebots/Library/Logs/Homebrew/envoy/01.bazelisk:
ERROR: An error occurred during the fetch of repository 'go_sdk':
   Traceback (most recent call last):
	File "/private/tmp/envoy-20210827-59011-735pgh/.brew_home/_bazel/6734651a1108d63ae9e743df04c9a20c/external/io_bazel_rules_go/go/private/sdk.bzl", line 98, column 13, in _go_download_sdk_impl
		fail("unsupported platform {}".format(platform))
Error in fail: unsupported platform darwin_arm64
ERROR: Error fetching repository: Traceback (most recent call last):
	File "/private/tmp/envoy-20210827-59011-735pgh/.brew_home/_bazel/6734651a1108d63ae9e743df04c9a20c/external/io_bazel_rules_go/go/private/sdk.bzl", line 98, column 13, in _go_download_sdk_impl
		fail("unsupported platform {}".format(platform))
Error in fail: unsupported platform darwin_arm64
ERROR: Analysis of target '//source/exe:envoy-static' failed; build aborted: unsupported platform darwin_arm64
INFO: Elapsed time: 83.843s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (18 packages loaded, 7 targets configured)
FAILED: Build did NOT complete successfully (18 packages loaded, 7 targets configured)

Envoy build process pulls Go 1.15.5 by Bazel (https://github.com/envoyproxy/envoy/blob/main/bazel/dependency_imports.bzl#L14), so it isn't relevant to system Go. M1 support should be ignored until Envoy supports that.

codefromthecrypt · 2021-08-27T02:55:52Z

@lizan that's great news. I'll remove the go dependency from the envoy formulae and if they work raise a PR so that people aren't distracted by this in the future.

codefromthecrypt · 2021-08-27T03:12:28Z

when merged, these should keep envoy from being considered when the go package changes

envoy - #84071
envoy@1.18 - #84072

carlocab · 2021-08-27T03:19:47Z

Great; thanks for the clarification!

carlocab

I think we're far enough along here that nearly all (if not all) the remaining failures should be fixed in time.

Thanks for the help, @samuel, @roopakv, @bouk, @bn4t, @imsodin, @gordonbondon, @AlekSi, @ucwong, @stefanb and @andig! (Apologies if I missed anyone.)

BrewTestBot · 2021-08-27T03:21:23Z

@carlocab has triggered a merge.

BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Aug 16, 2021

branchvincent mentioned this pull request Aug 16, 2021

go 1.16.7 #82758

Closed

This comment has been minimized.

Sign in to view

bendrucker mentioned this pull request Aug 18, 2021

build: bump to use go1.17 terraform-linters/tflint#1188

Merged

desimone mentioned this pull request Aug 18, 2021

ci: use go 1.17.x pomerium/pomerium#2492

Merged

3 tasks

This was referenced Aug 18, 2021

Update x/sys for go 1.17 ooni/probe-cli#438

Merged

Update x/sys for sdk to support go 1.17 pulumi/pulumi#7781

Merged

Update x/sys to support go 1.17 hashicorp/consul#10869

Merged

bassosimone mentioned this pull request Aug 18, 2021

cli: need to bump x/sys and bless new release to fix homebrew ooni/probe#1737

Closed

carlocab mentioned this pull request Aug 18, 2021

go 1.17 #83517

Closed

6 tasks

roopakv mentioned this pull request Aug 18, 2021

Replace x/sys for go 1.17 tarantool/cartridge-cli#618

Merged

3 tasks

This was referenced Aug 26, 2021

cartridge-cli: support go 1.17 #83997

Closed

flux: support go 1.17 #84002

Closed

carlocab mentioned this pull request Aug 26, 2021

v1.1.8 tarball checksum changed? semihalev/sdns#104

Closed

branchvincent mentioned this pull request Aug 26, 2021

modd: deprecate #84056

Closed

6 tasks

branchvincent mentioned this pull request Aug 26, 2021

devd: support go 1.17 #84062

Closed

6 tasks

codefromthecrypt mentioned this pull request Aug 26, 2021

Remove build dependency on golang envoyproxy/envoy#17886

Closed

This was referenced Aug 27, 2021

envoy: removes go dependency #84071

Closed

envoy@1.18: removes go dependency #84072

Closed

carlocab approved these changes Aug 27, 2021

View reviewed changes

BrewTestBot closed this in 439f5ca Aug 27, 2021

branchvincent deleted the bump-go-1.17 branch August 27, 2021 03:31

anajavi mentioned this pull request Aug 30, 2021

Logrus crashes on terminal check sirupsen/logrus#1275

Closed

chenrui333 mentioned this pull request Sep 3, 2021

build: update x/sys to support go1.17 newrelic/infrastructure-agent#712

Closed

branchvincent mentioned this pull request Sep 17, 2021

kubernetes-cli 1.22.2 #85274

Closed

github-actions bot added the outdated PR was locked due to age label Sep 27, 2021

github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go 1.17 #83413

go 1.17 #83413

branchvincent commented Aug 16, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SMillerDev commented Aug 17, 2021

roopakv commented Aug 17, 2021

carlocab commented Aug 17, 2021

This comment has been minimized.

samuel commented Aug 17, 2021

carlocab commented Aug 18, 2021

roopakv commented Aug 18, 2021 •

edited by branchvincent

Loading

blacktop commented Aug 19, 2021

carlocab commented Aug 26, 2021

codefromthecrypt commented Aug 26, 2021

branchvincent commented Aug 26, 2021

codefromthecrypt commented Aug 26, 2021

codefromthecrypt commented Aug 26, 2021 •

edited

Loading

codefromthecrypt commented Aug 26, 2021

codefromthecrypt commented Aug 26, 2021

keith commented Aug 26, 2021

codefromthecrypt commented Aug 27, 2021

lizan commented Aug 27, 2021

codefromthecrypt commented Aug 27, 2021

codefromthecrypt commented Aug 27, 2021

carlocab commented Aug 27, 2021

carlocab left a comment

BrewTestBot commented Aug 27, 2021

go 1.17 #83413

go 1.17 #83413

Conversation

branchvincent commented Aug 16, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SMillerDev commented Aug 17, 2021

roopakv commented Aug 17, 2021

carlocab commented Aug 17, 2021

This comment has been minimized.

samuel commented Aug 17, 2021

carlocab commented Aug 18, 2021

roopakv commented Aug 18, 2021 • edited by branchvincent Loading

Checksum mismatch

blacktop commented Aug 19, 2021

carlocab commented Aug 26, 2021

codefromthecrypt commented Aug 26, 2021

branchvincent commented Aug 26, 2021

codefromthecrypt commented Aug 26, 2021

codefromthecrypt commented Aug 26, 2021 • edited Loading

codefromthecrypt commented Aug 26, 2021

codefromthecrypt commented Aug 26, 2021

keith commented Aug 26, 2021

codefromthecrypt commented Aug 27, 2021

lizan commented Aug 27, 2021

codefromthecrypt commented Aug 27, 2021

codefromthecrypt commented Aug 27, 2021

carlocab commented Aug 27, 2021

carlocab left a comment

Choose a reason for hiding this comment

BrewTestBot commented Aug 27, 2021

branchvincent commented Aug 16, 2021 •

edited

Loading

roopakv commented Aug 18, 2021 •

edited by branchvincent

Loading

codefromthecrypt commented Aug 26, 2021 •

edited

Loading