datree: test #84567
Closed
datree: test #84567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
added
the
CI-no-fail-fast
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
datree-test
branch
from
995680d to
0755e21
Compare
|
so they pass, and this is what I observe locally: $ git -C $(brew --repo) checkout 6d2a2960fcdf5550fda796c67e283c98376ef607
$ git -C $(brew --repo homebrew/core) checkout d7ba094baa2de34a34e2fcbbb08ca7371955bfb1
$ brew install datree
$ brew test datree
==> Testing datree
==> /usr/local/Cellar/datree/0.9.0/bin/datree test /private/tmp/datree-test-20210902-40849-sas8y0/invalidK8sSchema.yaml 2>&1
==> /usr/local/Cellar/datree/0.9.0/bin/datree version
$ datree version
fatal error: unexpected signal during runtime execution
...It has something to do with the environment in the test runner that does not reproduce this. I can even put a $ datree version
0.9.0 |
|
Agree, looks like the CI did not catch anything with this commit, I have seen the same issue with |
|
got it, it's $ env -i PATH="$PATH" TERM="dumb" datree version
0.9.0
$ env -i PATH="$PATH" datree version
fatal error: unexpected signal during runtime execution |
|
Nice find. That is why CI failed catching it! |
|
given that, i can't think of how we could have realistically caught this. can you? |
|
yeah, I dont have any further idea, I am gonna close this PR for now. (feel free to reopen if you feel fit) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test PR to reproduce datreeio/datree#160
relates to #84566