Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octant, openshift-cli: fix gopath #86784

Closed
wants to merge 2 commits into from
Closed

octant, openshift-cli: fix gopath #86784

wants to merge 2 commits into from

Conversation

Git-Jiro
Copy link
Contributor

@Git-Jiro Git-Jiro commented Oct 7, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Remove GOPATH from octant and openshift-cli
Ref: #47627

@Git-Jiro
Copy link
Contributor Author

@carlocab do you know who can take a look at my PR here?

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Oct 13, 2021
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. A few comments.

Please use the preferred commit-message style for homebrew/core. We put the name of the formula first in commit-message headings.

For new formulae:

At Homebrew, we like to put the name of the formula up front like so: foobar 7.3 (new formula).

For existing formulae:

The preferred commit message format for simple version updates is foobar 7.3 and for fixes is foobar: fix flibble matrix..

Refer to the commit style guide for more details. Also, when making further changes to your pull request, adhere to the following guidelines to make sure that @BrewTestBot can merge your commits:

  • One formula per commit; one commit per formula.
  • Keep merge commits out of the pull request.

Formula/octant.rb Outdated Show resolved Hide resolved
@carlocab carlocab requested a review from dawidd6 October 13, 2021 04:57
@carlocab carlocab changed the title Fix gopath for octant and openshift-cli octant, openshift-cli: fix gopath Oct 13, 2021
Formula/octant.rb Outdated Show resolved Hide resolved
@Git-Jiro
Copy link
Contributor Author

@carlocab @dawidd6
Anything left for me to do before it can be approved?

Formula/octant.rb Outdated Show resolved Hide resolved
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@Git-Jiro
Copy link
Contributor Author

Hi @carlocab and @dawidd6,
do i see this correct, that the testbot only merged the octant fix, but ignored the openshift-cli change?
Should I create a new MR for that?

@dawidd6
Copy link
Member

dawidd6 commented Oct 14, 2021

Everything was merged fine.

@carlocab
Copy link
Member

Thanks for your contribution, @Git-Jiro.

@Git-Jiro
Copy link
Contributor Author

Ok, just saw it in the commit history of the master branch.

@Git-Jiro Git-Jiro deleted the fix_gopath branch October 14, 2021 09:58
@Git-Jiro
Copy link
Contributor Author

@carlocab, can I get an "hacktoberfest-accepted" label for this PR?
Because it looks like the "Hacktoberfest tracking" app thinks this PR was not accepted.

Thank you!

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue hacktoberfest-accepted outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants