Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrcpy 1.20 #89490

Closed
wants to merge 2 commits into from
Closed

scrcpy 1.20 #89490

wants to merge 2 commits into from

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Nov 15, 2021 •
edited
Loading

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` no Linux bottle Formula has no Linux bottle labels Nov 15, 2021
nevack
nevack reviewed Nov 16, 2021
View reviewed changes
Formula/scrcpy.rb
@@ -21,8 +21,8 @@ class Scrcpy < Formula
depends_on "sdl2"
Copy link
Contributor

@nevack nevack Nov 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add depends_on "libusb" for linux, because:

Add HID keyboard support on Linux (#2632)

@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 16, 2021
@nevack
Copy link
Contributor

nevack commented Nov 16, 2021 •
edited
Loading

@carlocab

../app/src/compat.h:57:7: error: expected identifier or '(' before '__extension__'
   57 | char *strdup(const char *s);
      |       ^~~~~~

I think we should patch this.
strdup is already defined C stdlib function in <string.h>.

Edit:
But it's under preprocessor guard, hmm
https://github.com/Genymobile/scrcpy/blob/master/app/src/compat.h#L56

@carlocab
Copy link
Member

Probably a similar issue to #85160 then

@carlocab carlocab added linux Linux is specifically affected ready to merge PR can be merged once CI is green labels Nov 16, 2021
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nevack nevack nevack left review comments

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. linux Linux is specifically affected no Linux bottle Formula has no Linux bottle outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bevanjkay @nevack @carlocab @BrewTestBot