This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
make brew update define tapped formula properly #21087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a tapped formula is a ruby file present: - in the root of the tap - in directory of the tap called Formula - in a directory of the tap called HomebrewFormula and nowhere else. this corrects an overzealous definition of tapped formula in the updater. (the correct definition has been in Pathname since e613cbe) refs Homebrew#19743
|
First build failed, but pushed a corrected commit as phinze/homebrew@74c7ca1 Not sure if the build will retrigger automatically or if there's a way to manually poke it |
|
Looking green now! Let me know if there's anything I can do to help this make it in! 👍 🌟 |
|
Thank you for working on this. I think it looks ready to go, I will plan to merge it later this evening. Certainly looking forward to having this resolved. |
|
Thanks again. |
|
To repeat Jack, thanks for this! |
handyman5
pushed a commit
to handyman5/homebrew
that referenced
this pull request
Oct 7, 2013
A tapped formula is a ruby file present: - in the root of the tap - in directory of the tap called Formula - in a directory of the tap called HomebrewFormula And nowhere else. This corrects an overzealous definition of tapped formula in the updater. (the correct definition has been in Pathname since e613cbe) Refs Homebrew#19743. Closes Homebrew#21087. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a tapped formula is a ruby file present:
and nowhere else. this corrects an overzealous definition of tapped
formula in the updater. (the correct definition has been in Pathname
since e613cbe)
refs #19743