Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct variables of 2020 and 2021 new data. #115

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Conversation

KHwong12
Copy link
Contributor

@KHwong12 KHwong12 commented Dec 25, 2023

Summary

This branch corrects variables (column names and values) of 2020 and 2021 new data.

Changes

The changes made in this PR are:

  1. Change the "SSPO" value in the district column of 2020 and 2021 data to "SSP". This keeps the district abbr in line with the original one.
  2. Treat observations with easting and northing values of 800000 as NA values instead of valid spatial location. In raw data, 800000 refers to missing values.
  3. Change the "collision_type" column variable in the pedestrian district dashboard to "collision_type_with_cycle". This replacement is missed in Feat: Add 2020 and 2021 collision data #113.

Check

  • (If UI & data are updated) The UI & data includes Traditional Chinese translation, with translation terms wrapped in i18n$t() and terms added to translation_zh.csv
  • The GitHub Actions workflows pass.

Note

Sequel for the leftover steps that should be completed in #113

…0 and 2021 new data

1. Change district of SSPO to SSP; 2. Treat 800000 Northing/Easting values as missing values
@KHwong12 KHwong12 merged commit 83823f0 into main Dec 26, 2023
4 checks passed
@KHwong12 KHwong12 deleted the fix/raw-20-21-data branch December 26, 2023 12:41
@KHwong12
Copy link
Contributor Author

Code used to correct and clean data available in https://gist.github.com/KHwong12/4e5d7e628ed8888cabe9cf511af323a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant