Add image stamping for TextField elements #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopding
requested changes
Dec 13, 2020
There was a problem hiding this comment.
@btecu Good idea! A couple things before merging:
- Would you please update one of the existing integration tests with form field to exercise this new method on
TextField? - Can you create a new enum called
ImageAlignmentrather than using theTextAlignmentenum? Their values happen to be the same right now, but I'd prefer to keep them separated.
- Add test for image stamping for TextField elements
|
@Hopding feedback addressed! |
Hopding
added a commit
that referenced
this pull request
Dec 20, 2020
* Add image stamping for TextField elements (#700) * Add image stamping for TextField elements * - Add `ImageAlignment` - Add test for image stamping for TextField elements * Cleanup Co-authored-by: Bj Tecu <btecu@users.noreply.github.com>
1 task
Hopding
added a commit
that referenced
this pull request
Aug 30, 2021
* Add image stamping for TextField elements (#700) * Add image stamping for TextField elements * - Add `ImageAlignment` - Add test for image stamping for TextField elements * Cleanup Co-authored-by: Bj Tecu <btecu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows stamping an image on a
TextFieldelement in addition toButtonelements.Additionally, it now handles alignment, defaulting to
CenterforButtonand usingTextAlignmentforTextField.