[Fix #25] Fixing validation date offset #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warlocklogan
force-pushed
the
25-validation-date-offset
branch
from
2866529
to
fb6161a
Compare
|
Migration take currently approx 1s / 1000 record |
|
Hello @Creamaster @Max-282 une relecture s'il vous plaît. |
Creamaster
approved these changes
Nov 30, 2023
payment_payfip/migrations/11.0.22.08.16/pre-french-tz-to-utc-payfip-transaction-date-.py
Outdated
Show resolved
Hide resolved
Max-282
approved these changes
Dec 6, 2023
Currently, validation dates on transactions are stored in the French timezone, but in Odoo the timezone is expected to be in UTC. A minor fix is needed in the _payfip_evaluate_data method to convert the timezone into a UTC one. Migrate all previous dates validations to fix the timezone issue. All transactions are processed in chunk of one hundred. Signed-off-by: Logan Gonet <logan.gonet@horanet.com>
Warlocklogan
force-pushed
the
25-validation-date-offset
branch
from
4901966
to
68b7dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, validation dates on transactions are stored in the French
timezone but in Odoo the timezone attended is UTC. A minor fix is needed
in the _payfip_evaluate_data method for passing the timezone into an UTC
one.
Signed-off-by: Logan Gonet logan.gonet@horanet.com