-
Notifications
You must be signed in to change notification settings - Fork 60
Configurable check for valid Equihash <n,k> solutions #2
Configurable check for valid Equihash <n,k> solutions #2
Conversation
Hi, the PR reintroduce the equihash c implementation that was substituted for a known vulnerability. |
Hi! Please check now. |
Hi! Yes it's ok now. |
Concept ACK. |
Sorry I forgot to copy changes from my local repository to github master branch. |
It maybe out of the scope of this PR, but BTG and BTCZ both have plans to use a different personalization string than ZCash. In BTCZ's case it will change from |
Hi, for backward compatibility it's needed to have the verify method if called with two parameters defaulting to the previous n,k values. |
Hi! I added backward compatibility and updated the test to verify results with or without passing n, k. |
utACK |
This PR, together with those to be applied on node-stratum-pool and z-nomp, allows to install a pool server based on z-nomp able to manage and validate the following equihash solutions:
Dependencies:
z-classic/node-stratum-pool#35
z-classic/z-nomp#348