Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/g drive #171

Merged
merged 178 commits into from
Aug 28, 2024
Merged

Feature/g drive #171

merged 178 commits into from
Aug 28, 2024

Conversation

ValbuenaG
Copy link
Contributor

For more information on contributing to Tella source code, see the Contributor Guidelines.

Type of change

Description:

Select the type of change(s) made in this pull request:

  • Bug fix (Fixes an issue)
  • New feature (Adds functionality)
  • Documentation (Fix to documentation)

Fixes #issue-number

Proposed changes

gus valbuena and others added 30 commits July 1, 2024 14:28
implementing google sdk
2aee336
@dhekra-rouatbi
Move dissmiss views to resetApp function
4db1ebe
add selected type of drive connection view
1853d08
add SelectSharedDrive view
851aa05
mock shared drives
ed6658e
create drive folder view
d1c5418
basic implemantation of d-drive library
b2bff3e
re-use successLoginView
a5c20fb
navigate from select shared drive to success
d4ef6a9
final tweaks
4dc3e10
move google signIn to next button
82e3746
refactor buttonViews function in serverSelection class
4474e91
move gDrive login logic to separate function
38168f3
create gDrive repository and update view models
c081b4a
add gdrive url to TellaURL list
05203a1
add isValid constraint when creating a folder in gDrive
acb0400
fix hardcoded strings, add space to VStacks and overall refactor
0cdb2d0
add serverConnectinoType extension for successLoginView
cfebc5d
add domain model for shared drives
5cc647e
add combine in gDriveRepository
8cfd528
add combine to the rest of the gDrive endpoints
1a6aa4a
remove toast if user is not authenticated
28f6a06
add async await for gDrive methods
af3cab6
implementing google sdk
1c4e420
basic implemantation of d-drive library
8bdd46e
final tweaks
49ce550
add isValid constraint when creating a folder in gDrive
83df535
implementing google sdk
c12a50e
basic implemantation of d-drive library
5055d27
create folder in g-drive
8f77e2f
@Rimktarii
Copy link
Contributor

Issue faced:
When I click multiple times on Next button, it is not working properly. Maybe we can add a loader when clicking on Next to avoid this case

gdriv.mp4

@dhekra-rouatbi dhekra-rouatbi merged commit 46eee6f into develop Aug 28, 2024
@dhekra-rouatbi dhekra-rouatbi deleted the feature/g-drive branch August 28, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rimktarii Rimktarii Rimktarii left review comments

@dhekra-rouatbi dhekra-rouatbi dhekra-rouatbi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValbuenaG @dhekra-rouatbi @Rimktarii