Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Tests] Fix Terminal entry test #143

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

ingrinder
Copy link
Collaborator

Pretty simple bugfix - I noticed this test has been failing on my system so I don't have the latest Archey version! 😱

Description

s/archey.colors.Colors/archey.colors.Style in test_archey_terminal.py

Reason and / or context

😃

How has this been tested ?

It makes the test pass!

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@ingrinder ingrinder added the bug 🐛 A real glitch has been found label Jan 7, 2024
Copy link
Owner

@HorlogeSkynet HorlogeSkynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ! Definitely a fix-up for 44a357e; I add it to your commit message 👍

@HorlogeSkynet HorlogeSkynet merged commit 56e36c0 into master Jan 7, 2024
26 checks passed
@HorlogeSkynet HorlogeSkynet deleted the bug/terminal_test branch January 7, 2024 08:49
@HorlogeSkynet HorlogeSkynet added this to the v4.14.3.0 milestone Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 A real glitch has been found
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants