-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Adds (Nerd Fonts) icons for entries #144
Conversation
I have noticed the following: Integration / Lint Python sources (pull_request)
|
That error is from the code formatter, |
Thank you. I will always use Black now. |
@Tobilike I just pushed a small change, hope that's alright. This LGTM now! |
@ingrinder
I must have done something wrong with git at the moment. Give me some time to understand. Everything is fine in my local copy. |
… unexpected. I have turned the icons on in my config. For testing.
This behaves strangely. |
There are security checks done on file permissions. But unit tests must not depend on external environment. |
Thank you, now I understand it better. |
Hello @Tobilike, I've pushed some changes :
Please tell me what you think about them before we merge this branch 🙂 Bye 👋 |
I've looked at it, tested it, and I think it's great. And thanks to HorlogeSkynet, ingrinder for the teamwork. I was able to learn a lot from it. |
Possibly all of them have now worked:
Please have a look there:
#141