This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Text expansion shortcut #1057
Merged
Text expansion shortcut #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now in generally ES6-accepted notation.
jkleinsc
suggested changes
Apr 19, 2017
There was a problem hiding this comment.
@tangollama looks good overall, but the translations need to be camelCased instead of using underscores. Can you also merge in the latest from master?
app/locales/en/translations.js
Outdated
| @@ -208,6 +208,17 @@ export default { | |||
| messages: { roleSaved: 'The {{roleName}} role has been saved.' }, | |||
| titles: { roleSaved: 'Role Saved' } | |||
| }, | |||
| text_replacements: { | |||
There was a problem hiding this comment.
@tangollama these need to be camel cased.
|
@jkleinsc bump. Changes checked in. |
jkleinsc
approved these changes
Apr 19, 2017
|
I like this. It would really help with notes._ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based entirely on the work of @eddiesholl in 2016, this is the completed feature for review.
Changes proposed in this pull request:
cc @HospitalRun/core-maintainers