Move svelte, sveltekit and vite into peerDependencies #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 088a020 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdini-docs-next canceled.
|
✅ Deploy Preview for houdinigraphql canceled.
|
AlecAivazis
previously approved these changes
Dec 2, 2024
|
I think it may be worth considering doing the same with vite |
Ah yeah good point. I might probably also move svelte-kit as well... |
SeppahBaws
changed the title
SeppahBaws
force-pushed
the
svelte-peerdependency
branch
2 times, most recently
from
3dada55 to
9801cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Svelte update added a new element (
<svelte:boundary>). However, upgrading an existing houdini + svelte project to this latest version gives errors when generating, as the version of the svelte compiler that houdini uses is outdated.By moving the svelte dependency into peerDependencies, we use the svelte version that the project is using. The only requirement we now have is that it matches
^5.0.0.(The updated wrangler version in e2e/react is because I was having compilation errors in better-sqlite3 while installing)
To help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changeset