Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credentials key, value order #1400

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

damoonrashidi
Copy link
Contributor

The property is called credentials and the value include. This only touches documentation so no tests have been changed.

Fixes #TICKET

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

The property is called `credentials` and the value `include`.
Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: c12e283

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for houdini-docs-next ready!

Name Link
🔨 Latest commit c12e283
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/6752ff6389900c0008438b94
😎 Deploy Preview https://deploy-preview-1400--houdini-docs-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for houdinigraphql ready!

Name Link
🔨 Latest commit c12e283
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/6752ff63ed847600086480b9
😎 Deploy Preview https://deploy-preview-1400--houdinigraphql.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlecAivazis
Copy link
Collaborator

Thanks for the quick fix!

@AlecAivazis AlecAivazis merged commit 22e1955 into HoudiniGraphql:main Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants