use the correct tag name for constructing new elements (issue #127)

HtmlUnit · Nov 13, 2024 · 2c357f8 · 2c357f8
1 parent d18d662
commit 2c357f8
Show file tree

Hide file tree

Showing 515 changed files with 128 additions and 7,261 deletions.
diff --git a/src/main/java/org/htmlunit/cyberneko/html/dom/HTMLDocumentImpl.java b/src/main/java/org/htmlunit/cyberneko/html/dom/HTMLDocumentImpl.java
@@ -533,13 +533,13 @@ public Element createElement(final String tagName) throws DOMException {
             // owner document and a tag name. Use the constructor to instantiate
             // a new object and return it.
             try {
-                return htmlHolder.ctr_.newInstance(this, htmlHolder.tagName_);
+                return htmlHolder.ctr_.newInstance(this, tagName);
             }
             catch (final Exception e) {
-                throw new IllegalStateException("HTM15 Tag '" + tagName + "' associated with an Element class that failed to construct.\n" + tagName, e);
+                throw new IllegalStateException("HTM15 Tag '" + tagName + "' associated with an Element class that failed to construct.", e);
             }
         }
-        return new HTMLElementImpl(this, tagName.toUpperCase(Locale.ENGLISH));
+        return new HTMLElementImpl(this, tagName);
     }
 
     /**

diff --git a/src/test/java/org/htmlunit/cyberneko/DOMFragmentParserTest.java b/src/test/java/org/htmlunit/cyberneko/DOMFragmentParserTest.java
@@ -50,15 +50,15 @@ public void attrEndingWithCRAtEndOfStream() {
      */
     @Test
     public void invalidProcessingInstruction() throws Exception {
-        doTest("<html><?9 ?></html>", "<HTML/>");
+        doTest("<html><?9 ?></html>", "<html/>");
     }
 
     /**
      * See <a href="http://sourceforge.net/support/tracker.php?aid=2828534">Bug 2828534</a>.
      */
     @Test
     public void invalidAttributeName() throws Exception {
-        doTest("<html 9='id'></html>", "<HTML/>");
+        doTest("<html 9='id'></html>", "<html/>");
     }
 
     private static void doTest(final String html, final String expected) throws Exception {

diff --git a/src/test/java/org/htmlunit/cyberneko/xerces/dom/HTMLDocumentImplTest.java b/src/test/java/org/htmlunit/cyberneko/xerces/dom/HTMLDocumentImplTest.java
@@ -0,0 +1,117 @@
+/*
+ * Copyright (c) 2002-2009 Andy Clark, Marc Guillemot
+ * Copyright (c) 2017-2024 Ronald Brill
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.htmlunit.cyberneko.xerces.dom;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.StringReader;
+
+import org.htmlunit.cyberneko.html.dom.HTMLDocumentImpl;
+import org.htmlunit.cyberneko.parsers.DOMParser;
+import org.junit.jupiter.api.Test;
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+import org.xml.sax.InputSource;
+
+/**
+ * Unit tests for {@link HTMLDocumentImpl}.
+ *
+ * @author Ronald Brill
+ */
+public class HTMLDocumentImplTest {
+
+    @Test
+    public void tagName() throws Exception {
+        final String html = "<HTML><head></head>"
+                + "<bODy>"
+                + "<DIv>abc</DIv>"
+                + "</bodY></HTML>";
+
+        DOMParser parser = new DOMParser(HTMLDocumentImpl.class);
+//        parser.setProperty("http://cyberneko.org/html/properties/names/elems", "lower");
+//        parser.setProperty("http://cyberneko.org/html/properties/names/attrs", "lower");
+
+//        parser.setProperty("http://cyberneko.org/html/properties/names/elems", "upper");
+//        parser.setProperty("http://cyberneko.org/html/properties/names/attrs", "upper");
+
+        parser.parse(new InputSource(new StringReader(html)));
+        Document doc = parser.getDocument();
+
+        Element htmlElem = doc.getDocumentElement();
+        assertEquals("HTML", htmlElem.getTagName());
+
+        Element headElem = (Element) htmlElem.getChildNodes().item(0);
+        assertEquals("head", headElem.getTagName());
+
+        Element bodyElem = (Element) htmlElem.getChildNodes().item(1);
+        assertEquals("bODy", bodyElem.getTagName());
+
+        Element divElem = (Element) bodyElem.getChildNodes().item(0);
+        assertEquals("DIv", divElem.getTagName());
+    }
+
+    @Test
+    public void tagNameLower() throws Exception {
+        final String html = "<HTML><head></head>"
+                + "<bODy>"
+                + "<DIv>abc</DIv>"
+                + "</bodY></HTML>";
+
+        DOMParser parser = new DOMParser(HTMLDocumentImpl.class);
+        parser.setProperty("http://cyberneko.org/html/properties/names/elems", "lower");
+
+        parser.parse(new InputSource(new StringReader(html)));
+        Document doc = parser.getDocument();
+
+        Element htmlElem = doc.getDocumentElement();
+        assertEquals("html", htmlElem.getTagName());
+
+        Element headElem = (Element) htmlElem.getChildNodes().item(0);
+        assertEquals("head", headElem.getTagName());
+
+        Element bodyElem = (Element) htmlElem.getChildNodes().item(1);
+        assertEquals("body", bodyElem.getTagName());
+
+        Element divElem = (Element) bodyElem.getChildNodes().item(0);
+        assertEquals("div", divElem.getTagName());
+    }
+
+    @Test
+    public void tagNameUpper() throws Exception {
+        final String html = "<HTML><head></head>"
+                + "<bODy>"
+                + "<DIv>abc</DIv>"
+                + "</bodY></HTML>";
+
+        DOMParser parser = new DOMParser(HTMLDocumentImpl.class);
+        parser.setProperty("http://cyberneko.org/html/properties/names/elems", "upper");
+
+        parser.parse(new InputSource(new StringReader(html)));
+        Document doc = parser.getDocument();
+
+        Element htmlElem = doc.getDocumentElement();
+        assertEquals("HTML", htmlElem.getTagName());
+
+        Element headElem = (Element) htmlElem.getChildNodes().item(0);
+        assertEquals("HEAD", headElem.getTagName());
+
+        Element bodyElem = (Element) htmlElem.getChildNodes().item(1);
+        assertEquals("BODY", bodyElem.getTagName());
+
+        Element divElem = (Element) bodyElem.getChildNodes().item(0);
+        assertEquals("DIV", divElem.getTagName());
+    }
+}
diff --git a/.../resources/org/htmlunit/cyberneko/testfiles/a/test-a-around-applet.html.canonical-domhtml b/.../resources/org/htmlunit/cyberneko/testfiles/a/test-a-around-applet.html.canonical-domhtml
diff --git a/...test/resources/org/htmlunit/cyberneko/testfiles/a/test-a-around-dd.html.canonical-domhtml b/...test/resources/org/htmlunit/cyberneko/testfiles/a/test-a-around-dd.html.canonical-domhtml
diff --git a/...rces/org/htmlunit/cyberneko/testfiles/a/test-a-content-div-content.html.canonical-domhtml b/...rces/org/htmlunit/cyberneko/testfiles/a/test-a-content-div-content.html.canonical-domhtml
diff --git a/...st/resources/org/htmlunit/cyberneko/testfiles/a/test-a-content-div.html.canonical-domhtml b/...st/resources/org/htmlunit/cyberneko/testfiles/a/test-a-content-div.html.canonical-domhtml
diff --git a/...st/resources/org/htmlunit/cyberneko/testfiles/a/test-a-div-content.html.canonical-domhtml b/...st/resources/org/htmlunit/cyberneko/testfiles/a/test-a-div-content.html.canonical-domhtml
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/a/test-a-div.html.canonical-domhtml b/src/test/resources/org/htmlunit/cyberneko/testfiles/a/test-a-div.html.canonical-domhtml
diff --git a/...est/resources/org/htmlunit/cyberneko/testfiles/a/test-a_around-ins.html.canonical-domhtml b/...est/resources/org/htmlunit/cyberneko/testfiles/a/test-a_around-ins.html.canonical-domhtml
diff --git a/...t/resources/org/htmlunit/cyberneko/testfiles/a/test-a_around-label.html.canonical-domhtml b/...t/resources/org/htmlunit/cyberneko/testfiles/a/test-a_around-label.html.canonical-domhtml
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/a/test-a_closes_a.html.canonical-domhtml b/src/test/resources/org/htmlunit/cyberneko/testfiles/a/test-a_closes_a.html.canonical-domhtml
diff --git a/...s/org/htmlunit/cyberneko/testfiles/a/test-a_closes_a_div_inbetween.html.canonical-domhtml b/...s/org/htmlunit/cyberneko/testfiles/a/test-a_closes_a_div_inbetween.html.canonical-domhtml
diff --git a/...s/org/htmlunit/cyberneko/testfiles/a/test-a_closes_a_tag_inbetween.html.canonical-domhtml b/...s/org/htmlunit/cyberneko/testfiles/a/test-a_closes_a_tag_inbetween.html.canonical-domhtml
diff --git a/.../resources/org/htmlunit/cyberneko/testfiles/a/test-a_href-around-p.html.canonical-domhtml b/.../resources/org/htmlunit/cyberneko/testfiles/a/test-a_href-around-p.html.canonical-domhtml
diff --git a/.../resources/org/htmlunit/cyberneko/testfiles/a/test-a_name-around-p.html.canonical-domhtml b/.../resources/org/htmlunit/cyberneko/testfiles/a/test-a_name-around-p.html.canonical-domhtml
diff --git a/...rces/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-applet.html.canonical-domhtml b/...rces/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-applet.html.canonical-domhtml
diff --git a/...rces/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-center.html.canonical-domhtml b/...rces/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-center.html.canonical-domhtml
diff --git a/...sources/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-del.html.canonical-domhtml b/...sources/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-del.html.canonical-domhtml
diff --git a/...sources/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-dir.html.canonical-domhtml b/...sources/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-dir.html.canonical-domhtml
diff --git a/...esources/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-dt.html.canonical-domhtml b/...esources/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-dt.html.canonical-domhtml
diff --git a/...es/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-fieldset.html.canonical-domhtml b/...es/org/htmlunit/cyberneko/testfiles/abbr/test-abbr-around-fieldset.html.canonical-domhtml