Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isSecureContext not recognized in JavaScript #573

Closed
MarkEWaite opened this issue Mar 30, 2023 · 4 comments
Closed

isSecureContext not recognized in JavaScript #573

MarkEWaite opened this issue Mar 30, 2023 · 4 comments
Assignees

Comments

@MarkEWaite
Copy link

@jtnord of the Jenkins project found that automated tests fail when isSecureContext is checked in JavaScript of a page being tested with HtmlUnit. JENKINS-70895 is the Jenkins issue report.

We've inserted a workaround into the problematic Jenkins code that avoids evaluating isSecureContext when running our automated tests. See the workaround at:

@rbri
Copy link
Member

rbri commented Mar 31, 2023

Thanks for the report, will make this function available in 3.1.0.

@rbri rbri self-assigned this Mar 31, 2023
rbri added a commit that referenced this issue Mar 31, 2023
rbri added a commit that referenced this issue Mar 31, 2023
@rbri
Copy link
Member

rbri commented Mar 31, 2023

have done a first impl - please try with the current 3.1.0 snapshot

@MarkEWaite
Copy link
Author

Sincere apologies @rbri but I won't be able to try it with the current 3.1.0 snapshot. I had to rely on @jtnord to duplicate it in his environment.

@rbri
Copy link
Member

rbri commented May 16, 2023

3.2.0 is now available, will close this.
@MarkEWaite please open a new one if this is still a problem (or you find something new ;-))

@rbri rbri closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants