GitHub actions for pull requests #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Strickroth <email@cs-ware.de>
Signed-off-by: Sven Strickroth <email@cs-ware.de>
This required to adjust CodeStyleTest to have a unique output format. Signed-off-by: Sven Strickroth <email@cs-ware.de>
Signed-off-by: Sven Strickroth <email@cs-ware.de>
csware
changed the title
|
Thanks a lot, personally i'm not a big fan of all these github actions (because of the missing result visualizations) but i think this will definitely help. Maybe we can introduce branch builds (like here https://jenkins.wetator.org/job/HtmlUnit%20-%20Library%20Tests/) for the core test (https://jenkins.wetator.org/job/HtmlUnit%20-%20Headless/) suite on jenkins also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prepared a few GitHub actions so that people who open a pull request (and you) get some comments about the code.
An example with check results can be seen here: csware#4 and inline check results on https://github.com/csware/htmlunit/pull/4/files
Btw. rights now it quite often failws because
https://oss.sonatype.org/is kinda unstable (it's slow and often results in a 502 Bad gateway. Maybe using the GitHub package repository may make sense.