test: fix: add status sub resource to fake clients #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang Wei <kweizh@gmail.com>
Huang-Wei
reviewed
Jul 28, 2023
| @@ -237,7 +237,10 @@ func setUpEQ(ctx context.Context, | |||
| s := scheme.Scheme | |||
| utilruntime.Must(v1alpha1.AddToScheme(s)) | |||
|
|
|||
| client := fake.NewClientBuilder().WithScheme(s).Build() | |||
| client := fake.NewClientBuilder(). | |||
Huang-Wei
pushed a commit
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Zhang Wei <kweizh@gmail.com>
|
From the release notes of controller-runtime v0.15.0:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
ctrl runtime added a subresource option to fake client in 0.15, make it failed to patch eq and podgroup.
also found a failing test case, changed it together
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?