WIP: Release 4.2.0 - Changes config implementation #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix polyfill error with Kint dependency
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=============================================
+ Coverage 35.81% 57.16% +21.35%
+ Complexity 5435 5385 -50
=============================================
Files 144 151 +7
Lines 17293 17109 -184
=============================================
+ Hits 6193 9780 +3587
+ Misses 11100 7329 -3771
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
There are too many results to compare View more on Code Climate. |
|
SonarCloud Quality Gate failed.
|
|
Hey, I'd like to help finishing this up, do you have a list of what's pending or some other way for me to know where to start giving a hand? |
alexvarden
suggested changes
Feb 15, 2023
| list($short, $full) = explode('|', strftime('%b|%B', strtotime("2001-${i}-01"))); | ||
| $this->iShortMonth[$aLocale][] = ucfirst($short); | ||
| $this->iMonthName[$aLocale][] = ucfirst($full); | ||
| list($short, $full) = explode('|', strftime('%b|%B', strtotime("2001-${i}-01"))); |
There was a problem hiding this comment.
strftime is deprecated as of php8.1 https://www.php.net/manual/en/function.strftime.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.