Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

[enhancement] Soundcloud/other embeds #136

Closed
guillaumevidal opened this issue Mar 17, 2015 · 13 comments
Closed

[enhancement] Soundcloud/other embeds #136

guillaumevidal opened this issue Mar 17, 2015 · 13 comments

Comments

@guillaumevidal
Copy link
Contributor

It would be nice to be able to embed Soundclound tracks/albums to hubpress posts.
I didn't find anything conclusive about using html in the posts, I think that's not supported.
So, feature request: because Youtube isn't everything ™️

@jaredmorgs
Copy link
Contributor

http://asciidoctor.org/docs/user-manual/#audio should work if you
substitute the local file in the example for the URL of the Soundcloud
track. Right?

On Tue, Mar 17, 2015, 20:14 Guillaume Vidal notifications@github.com
wrote:

It would be nice to be able to embed Soundclound tracks/albums to hubpress
posts.
I didn't find anything conclusive about using html in the posts, I think
that's not supported.
So, feature request: because Youtube isn't everything [image: ™️]


Reply to this email directly or view it on GitHub
#136.

@anthonny
Copy link
Member

@jaredmorgs i don't think that audio display the beautiful player of soundcloud, but we can write a macro in the asciidoctor project.

@guillaumevidal
Copy link
Contributor Author

Thanks, that's awesome!
Thanks for checking out the track too 😉
Would the Audio tag actually work with, for instance, a soundcloud url, which doesn't give you the actual filename anywhere?

@jaredmorgs
Copy link
Contributor

The only way to find out is to give it a go, Guillaume. ;)

On Wed, Mar 18, 2015, 21:54 Guillaume Vidal notifications@github.com
wrote:

Thanks, that's awesome!
Thanks for checking out the track too [image: 😉]
Would the Audio tag actually work with, for instance, a soundcloud url,
which doesn't give you the actual filename anywhere?


Reply to this email directly or view it on GitHub
#136 (comment)
.

@anthonny
Copy link
Member

Thanks, that's awesome!

I'm so glad each time i'm reading this kind of comment 😃

@guillaumevidal
Copy link
Contributor Author

@jaredmorgs : Results are in, it doesn't work !
Anyway, this is resolved, closing.

@guillaumevidal
Copy link
Contributor Author

As it turns out, the passthrough doesn't seem to work with another iframe embed, this one from bandcamp:

https://guillaumevidal.github.io/2015/03/17/Jam-of-the-Day-2.html

https://raw.githubusercontent.com/guillaumevidal/guillaumevidal.github.io/master/_posts/2015-03-17-Jam-of-the-Day-2.adoc

It works in the preview but not in the post (at least I can't see it from latest chrome, ie, and android chrome).

@anthonny
Copy link
Member

In the source of your iframe, remove the http: and keep //bandcamp...

https://demo-hubpress.github.io/2015/03/19/Test.html

https://raw.githubusercontent.com/demo-hubpress/demo-hubpress.github.io/master/_posts/2015-03-19-Test.adoc

Your blog is exposed on https and your iframe point on a source in http (mix content)

capture

It seems you work in http when you admin your hubpress (that's why it workss in the preview), you should use https too.

@guillaumevidal
Copy link
Contributor Author

Haha, that was quick!
Thanks, I see. I must remember to check the console next time something doesn't look right...

@anthonny
Copy link
Member

Feel free to reopen if necessary 😄

@heyallan
Copy link

heyallan commented Apr 6, 2015

README states that embeds from YouTube and Vimeo are possible. Good.
Now it could be also helpful to add a small note stating that other embeds are also possible. With a link to Block passthroughs maybe (?)

jaredmorgs pushed a commit that referenced this issue Sep 8, 2015
#136 which described issues with embedding audio content from BandCamp and SoundCloud. I added the bandcamp example and explained that you can't have mixed protocols.
@jaredmorgs
Copy link
Contributor

I've added this information to the /development branch of the README.adoc.

Thanks everyone for your efforts in working out how to do this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants