-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for upstream groups #179
Conversation
@tpetr meant to comment yesterday, two things:
|
Thanks for the feedback, I have an internal TODO to re-add validation on the group field. |
public boolean sameAs(UpstreamInfo that) { | ||
return upstream.equals(that.upstream) && group.equals(that.group); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is mostly just stylistic, but I'd personally make this a static method named something like UpstreamInfo.upstreamsAndGroupMatch(UpstreamInfo a, UpstreamInfo b)
group
field toUpstreamInfo
class (defaults toDEFAULT
if absent)upstreamGroups
field toServiceContext
class (the handlebars templates use this). Upstreams without agroup
value are added to thedefault
group.upstreams
list inServiceContext
is not affected -- this will contain all upstreams.@ssalinas