Restore compatibility with former BaragonGroup #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restores compatiblity with the old BaragonGroup serialization format by changing the name of the added field. That is, earlier changes had swapped the type of the `sources` field to use `TrafficSource` rather than strings; this swaps it back and puts `TrafficSource`s on a `trafficSource` field. This makes the new version compatible with anything using a prior version of the source of this project.
ssalinas
reviewed
Feb 3, 2017
| this.domains = Objects.firstNonNull(domains, Collections.<String>emptySet()); | ||
| this.domains = MoreObjects.firstNonNull(domains, Collections.<String>emptySet()); | ||
|
|
||
| if (sources == null) { |
There was a problem hiding this comment.
I think we can be a bit more clear about what is going on here, it's a bit hard to reason about this way. Maybe something like this?
this.sources = MoreObjects.firstNonNull(sources, Collections.<String>emptySet());
if (trafficSources == null) {
this.trafficSources = sources.forEach((source) -> new TrafficSource(source, TrafficSourceType.CLASSIC));
} else {
this.trafficSources = trafficSources;
}might have to make sure the most recent stuff is merged in to use the java8 bits, but it would be cleaner/easier to read without having to have the static methods
That is, sources is always just an empty set. When it is input it is replaced with an empty set.
Add an explicit type argument to help Java out with the type checking. In theory this shouldn't matter, but as they say, the difference between theory and practice is smaller in theory than it is in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores compatibility with the old
BaragonGroupserialization format bychanging the name of the added field. That is, earlier changes had
swapped the type of the
sourcesfield to useTrafficSourceratherthan strings; this swaps it back and puts
TrafficSources on atrafficSourcefield.This makes the new version compatible with anything using a prior
version of the source of this project.
/cc @ssalinas