React-ify Request Detail page #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the ReactDetail page over to React. There aren't really any actions on this page, so this is pretty much all of it.
ssalinas
reviewed
Feb 10, 2017
| @@ -0,0 +1,101 @@ | |||
| import React from 'react'; | |||
| import _ from 'underscore'; | |||
There was a problem hiding this comment.
_ should be available globally, shouldn't need this import
ssalinas
reviewed
Feb 10, 2017
| serviceId: Utils.maybe(state, ['api', 'requestResponse', ownProps.params.requestId, 'data', 'request', 'loadBalancerService', 'serviceId']), | ||
| agentResponses: Utils.maybe(state, ['api', 'requestResponse', ownProps.params.requestId, 'data', 'agentResponses']), | ||
| message: Utils.maybe(state, ['api', 'requestResponse', ownProps.params.requestId, 'data', 'message']), | ||
| request: Utils.maybe(state, ['api', 'requestResponse', ownProps.params.requestId, 'data', 'request']), |
There was a problem hiding this comment.
migWe already have the response object in api. requestResponse.(requestId).data mapped to params on the line below this. Would be a bit cleaner to just use that rather that mapping each individual field we need to a param
ssalinas
reviewed
Feb 10, 2017
| agentResponses: PropTypes.object, | ||
| message: PropTypes.string, | ||
| request: PropTypes.object, | ||
| response: PropTypes.object, |
There was a problem hiding this comment.
Since we know the form response takes, we can actually be more detailed here using PropTypes.shape
e.g.
response: PropTypes.shape({
loadBalancerRequestId: PropTypes.string,
agentResponses: PropTypes.arrayOf(PropTypes.shape({ ...
...
This principally involved changing where the destructuring was taking place; in particular, it moved if from the HOC binding into the beginning of the render method. If also involved adding a loading icon to handle when the UI had yet to finish the request, and dropping the global `_` from being included in the vendor bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the RequestDetail page over to React.