Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit button to Navbar #216

Merged
merged 3 commits into from
Feb 21, 2017
Merged

Add edit button to Navbar #216

merged 3 commits into from
Feb 21, 2017

Conversation

PtrTeixeira
Copy link
Contributor

Add the edit button to the navbar. This behaves the same way as the existing system; it brings up a modal that prompts for the auth key and if successful, will store both the auth key and the 'can-edit' state in local storage / window.config.

Add the control to the top-right of the nav window to enable and disable
`allowEdit` state. This PR will also contain the collapse functionality
for the navbar.
Make the nav bar collapsible the same way as on the existing
application. That way you can expand the navbar to see all the links on
your phone, if you have a driving need to do so.
Copy link
Member

@ssalinas ssalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small comment on the form piece I think this will work for us. If we ever do JWTs for Singularity, maybe we can port it here as well and not have to worry about this piece

@@ -291,6 +292,22 @@ export default class FormModal extends React.Component {
</FormModal.FormItem>
);

case FormModal.INPUT_TYPES.PASSWORD:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be easier to add a parameter that can be passed to the STRING input type, or in some way reusing that code since this is the same save for the type="password" line

Formerly the code for the password input field was entirely duplicated
from the code for the password and duration fields.  This refactors that
slightly so the input type can be configured in the same way, but it
only uses the code for it once.
@ssalinas
Copy link
Member

👍 LGTM

@PtrTeixeira PtrTeixeira merged commit 8fd7b08 into react Feb 21, 2017
@PtrTeixeira PtrTeixeira deleted the react-navbar branch February 21, 2017 15:39
@ssalinas ssalinas modified the milestone: 0.5.0 May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants