Add default domains into all service definitions #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixed travis and got rid of a bunch of old Timed annotations we don't need anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the service state currently reads can often be misleading/incomplete. Currently Baragon will just assume that if a service's domain list doesn't specify a domain served by the current group it is being processed on, that the domain is the default for that group. When reading the service state json later, it does not include the default groups, which you then have to look up in baragon service.
This will add the default domain into the service state json for all new incoming requests as well as running a migration to hydrate existing state with default domains. This should be a no-op in terms of actual applied configs. I will still need to do a bit of testing to confirm that is the case